-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ChatObservationProperties.class missing logCompletion field and corresponding setter method. #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…y-response` Fixes spring-projectsGH-3151 Follow-up of commit ca843e8,`includeCompletion` is renamed to `logCompletion`. Signed-off-by: Yanming Zhou <[email protected]>
It should be fixed by #3156 |
Thanks @quaff. I also noticed that with RC-1 release the chat prompts are no longer shown in a tracing service (like Zipkin). Prior to the RC-1 release, I was able to see the prompts in tracing services like Zipkin, but with the RC-1 release, they have switched observability from tracing to logging. |
Thanks for catching this. We need to fix this issue, but, IMO, the observability features should still work as documented in the meantime. |
Thanks for clarifying. Prior to the RC-1 release, I was able to see the prompts in tracing services like Zipkin, but with the RC-1 release, it looks like observability has switched from tracing to logging. |
@jonatan-ivanov @shakuzen @ThomasVitale - thoughts? I think we could provide some additional configuration or example code to use an alternative configuration that reproduces the old behavior. |
See the discussions in the PR for the background: #3003
Those are not necessarily console logs. They are logs going to wherever you want them to go. Could you please also tell us what is your use-case to add this kind of data (large amount of text) to spans? |
@making has been making zipkin-otel which you can drop in an image and it can accept the logs as annotations https://github.com/openzipkin-contrib/zipkin-otel?tab=readme-ov-file#docker-images |
@iAMSagar44 , I've tried to factor out the handlers and filters (removed in RC1) into a standalone project: https://github.com/tzolov/observability-extensions |
…y-response` Fixes spring-projectsGH-3151 Follow-up of commit ca843e8,`includeCompletion` is renamed to `logCompletion`. Signed-off-by: Yanming Zhou <[email protected]> Signed-off-by: minsoo.nam <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
The ChatObservationProperties.class is missing the logCompletion field and its corresponding setter method.
As per the documentation, the following properties have changed in RC1 -
This is resulting in the following error -
"message": "'spring.ai.chat.observations.log-completion' is an unknown property. Did you mean 'spring.ai.chat.observations.log-prompt'?"
A similar error is noticed for the below property too, due to the missing field (logQueryResponse) in VectorStoreObservationProperties.class
spring.ai.vectorstore.observations.log-query-response
Spring AI version - 1.0.0-RC1
The text was updated successfully, but these errors were encountered: