Skip to content

Commit 771c044

Browse files
committed
Fix bug where column called updated_at was being skipped in readonly queries
1 parent d4666b6 commit 771c044

File tree

11 files changed

+40
-15
lines changed

11 files changed

+40
-15
lines changed

internal/codegen/golang/gen.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,12 +424,12 @@ func readOnly(queries []Query) []Query {
424424
}
425425

426426
qsql := strings.ToUpper(q.SQL)
427-
if !strings.Contains(qsql, "SELECT") {
427+
if !strings.Contains(qsql, "SELECT ") {
428428
continue
429429
}
430-
if strings.Contains(qsql, "INSERT") ||
431-
strings.Contains(qsql, "UPDATE") ||
432-
strings.Contains(qsql, "DELETE") {
430+
if strings.Contains(qsql, "INSERT ") ||
431+
strings.Contains(qsql, "UPDATE ") ||
432+
strings.Contains(qsql, "DELETE ") {
433433
continue
434434
}
435435

internal/endtoend/testdata/read_write_segregation/mysql/go/models.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/read_write_segregation/mysql/go/query.sql.go

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/read_write_segregation/mysql/go/read.go

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/read_write_segregation/mysql/query.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* name: GetUserByID :one */
2-
SELECT first_name, id, last_name FROM users WHERE id = sqlc.arg('target_id');
2+
SELECT first_name, id, last_name, updated_at FROM users WHERE id = sqlc.arg('target_id');
33

44
/* name: ListUsers :many */
55
SELECT first_name, last_name FROM users;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
CREATE TABLE users (
22
id SERIAL NOT NULL,
33
first_name varchar(255) NOT NULL,
4-
last_name varchar(255)
4+
last_name varchar(255),
5+
updated_at timestamp NULL DEFAULT CURRENT_TIMESTAMP
56
);
6-

internal/endtoend/testdata/read_write_segregation/postgresql/stdlib/go/models.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/read_write_segregation/postgresql/stdlib/go/query.sql.go

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/read_write_segregation/postgresql/stdlib/go/read.go

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/read_write_segregation/postgresql/stdlib/query.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* name: GetUserByID :one */
2-
SELECT first_name, id, last_name FROM users WHERE id = sqlc.arg('target_id');
2+
SELECT first_name, id, last_name, updated_at FROM users WHERE id = sqlc.arg('target_id');
33

44
/* name: ListUsers :many */
55
SELECT first_name, last_name FROM users;

0 commit comments

Comments
 (0)