ci: add database services for MSSQL testing

Add PostgreSQL, MySQL, and MSSQL database services to CI workflow.
This enables proper testing of all database engines including the
new MSSQL support.

Revert the graceful skipping code since CI now provides the required
databases.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: claude

.github/workflows/ci.yml

@@ -24,6 +24,39 @@ jobs:
         GOARCH: ${{ matrix.goarch }}
   test:
     runs-on: ubuntu-24.04
+    services:
+      postgres:
+        image: postgres:16
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: mysecretpassword
+          POSTGRES_DB: postgres
+        ports:
+          - 5432:5432
+        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
+      mysql:
+        image: mysql:9
+        env:
+          MYSQL_DATABASE: dinotest
+          MYSQL_ROOT_PASSWORD: mysecretpassword
+          MYSQL_ROOT_HOST: '%'
+        ports:
+          - 3306:3306
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5
+      mssql:
+        image: mcr.microsoft.com/mssql/server:2022-latest
+        env:
+          ACCEPT_EULA: Y
+          MSSQL_SA_PASSWORD: MySecretPassword1!
+          MSSQL_PID: Developer
+        ports:
+          - 1433:1433
+        options: >-
+          --health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P 'MySecretPassword1!' -Q 'SELECT 1' -C || exit 1"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 10
+          --health-start-period 30s
     steps:
     - uses: actions/checkout@v6
     - uses: actions/setup-go@v6
@@ -58,6 +91,9 @@ jobs:
         CI_SQLC_AUTH_TOKEN: ${{ secrets.CI_SQLC_AUTH_TOKEN }}
         SQLC_AUTH_TOKEN: ${{ secrets.CI_SQLC_AUTH_TOKEN }}
         CGO_ENABLED: "0"
+        POSTGRESQL_SERVER_URI: "postgres://postgres:mysecretpassword@localhost:5432/postgres?sslmode=disable"
+        MYSQL_SERVER_URI: "root:mysecretpassword@tcp(localhost:3306)/dinotest?parseTime=true"
+        MSSQL_SERVER_URI: "sqlserver://sa:MySecretPassword1!@localhost:1433?database=master"
 
   vuln_check:
     runs-on: ubuntu-24.04

internal/cmd/generate.go

@@ -293,16 +293,7 @@ func remoteGenerate(ctx context.Context, configPath string, conf *config.Config,
 	return output, nil
 }
 
-// parseResult indicates the outcome of parsing a SQL configuration
-type parseResult int
-
-const (
-	parseSuccess parseResult = iota
-	parseFailed
-	parseSkipped // Configuration was skipped (e.g., database unavailable)
-)
-
-func parse(ctx context.Context, name, dir string, sql config.SQL, combo config.CombinedSettings, parserOpts opts.Parser, stderr io.Writer) (*compiler.Result, parseResult) {
+func parse(ctx context.Context, name, dir string, sql config.SQL, combo config.CombinedSettings, parserOpts opts.Parser, stderr io.Writer) (*compiler.Result, bool) {
 	defer trace.StartRegion(ctx, "parse").End()
 	c, err := compiler.NewCompiler(sql, combo, parserOpts)
 	defer func() {
@@ -311,15 +302,8 @@ func parse(ctx context.Context, name, dir string, sql config.SQL, combo config.C
 		}
 	}()
 	if err != nil {
-		// Check if this is a database unavailability error (e.g., missing env var)
-		// In this case, skip the configuration gracefully rather than failing
-		if compiler.IsDatabaseUnavailable(err) {
-			fmt.Fprintf(stderr, "# package %s\n", name)
-			fmt.Fprintf(stderr, "skipping: %s\n", err)
-			return nil, parseSkipped
-		}
 		fmt.Fprintf(stderr, "error creating compiler: %s\n", err)
-		return nil, parseFailed
+		return nil, true
 	}
 	if err := c.ParseCatalog(sql.Schema); err != nil {
 		fmt.Fprintf(stderr, "# package %s\n", name)
@@ -330,7 +314,7 @@ func parse(ctx context.Context, name, dir string, sql config.SQL, combo config.C
 		} else {
 			fmt.Fprintf(stderr, "error parsing schema: %s\n", err)
 		}
-		return nil, parseFailed
+		return nil, true
 	}
 	if parserOpts.Debug.DumpCatalog {
 		debug.Dump(c.Catalog())
@@ -344,9 +328,9 @@ func parse(ctx context.Context, name, dir string, sql config.SQL, combo config.C
 		} else {
 			fmt.Fprintf(stderr, "error parsing queries: %s\n", err)
 		}
-		return nil, parseFailed
+		return nil, true
 	}
-	return c.Result(), parseSuccess
+	return c.Result(), false
 }
 
 func codegen(ctx context.Context, combo config.CombinedSettings, sql OutputPair, result *compiler.Result) (string, *plugin.GenerateResponse, error) {

internal/cmd/process.go

@@ -104,17 +104,11 @@ func processQuerySets(ctx context.Context, rp ResultProcessor, conf *config.Conf
 			packageRegion := trace.StartRegion(gctx, "package")
 			trace.Logf(gctx, "", "name=%s dir=%s plugin=%s", name, dir, lang)
 
-			result, status := parse(gctx, name, dir, sql.SQL, combo, parseOpts, errout)
-			switch status {
-			case parseFailed:
+			result, failed := parse(gctx, name, dir, sql.SQL, combo, parseOpts, errout)
+			if failed {
 				packageRegion.End()
 				errored = true
 				return nil
-			case parseSkipped:
-				// Configuration was skipped (e.g., database unavailable)
-				// This is not an error - just skip this configuration
-				packageRegion.End()
-				return nil
 			}
 			if err := rp.ProcessResult(gctx, combo, sql, result); err != nil {
 				fmt.Fprintf(errout, "# package %s\n", name)
@@ -128,15 +122,12 @@ func processQuerySets(ctx context.Context, rp ResultProcessor, conf *config.Conf
 	if err := grp.Wait(); err != nil {
 		return err
 	}
-	// Always print stderr buffers (includes skip messages and errors)
-	for i := range stderrs {
-		if stderrs[i].Len() > 0 {
+	if errored {
+		for i, _ := range stderrs {
 			if _, err := io.Copy(stderr, &stderrs[i]); err != nil {
 				return err
 			}
 		}
-	}
-	if errored {
 		return fmt.Errorf("errored")
 	}
 	return nil

internal/cmd/vet.go

@@ -484,14 +484,9 @@ func (c *checker) checkSQL(ctx context.Context, s config.SQL) error {
 		Debug: debug.Debug,
 	}
 
-	result, status := parse(ctx, name, c.Dir, s, combo, parseOpts, c.Stderr)
-	switch status {
-	case parseFailed:
+	result, failed := parse(ctx, name, c.Dir, s, combo, parseOpts, c.Stderr)
+	if failed {
 		return ErrFailedChecks
-	case parseSkipped:
-		// Configuration was skipped (e.g., database unavailable)
-		// This is not an error for vet - just skip this configuration
-		return nil
 	}
 
 	var prep preparer

internal/compiler/engine.go

@@ -15,7 +15,6 @@ import (
 	"github.com/sqlc-dev/sqlc/internal/engine/sqlite"
 	sqliteanalyze "github.com/sqlc-dev/sqlc/internal/engine/sqlite/analyzer"
 	"github.com/sqlc-dev/sqlc/internal/opts"
-	"github.com/sqlc-dev/sqlc/internal/shfmt"
 	"github.com/sqlc-dev/sqlc/internal/sql/catalog"
 	"github.com/sqlc-dev/sqlc/internal/x/expander"
 )
@@ -120,20 +119,12 @@ func NewCompiler(conf config.SQL, combo config.CombinedSettings, parserOpts opts
 		c.catalog = mssql.NewCatalog()
 		c.selector = newDefaultSelector()
 
-		// MSSQL requires database-only mode because the teesql parser
-		// doesn't provide AST node positions needed for query analysis
+		// MSSQL only supports database-only mode
 		if conf.Database == nil {
-			return nil, fmt.Errorf("%w: mssql engine requires database configuration", ErrDatabaseUnavailable)
+			return nil, fmt.Errorf("mssql engine requires database configuration")
 		}
-		hasURI := conf.Database.URI != ""
-		if hasURI && !conf.Database.Managed {
-			// Check if the URI is empty after environment variable substitution
-			replacer := shfmt.NewReplacer(nil)
-			expandedURI := replacer.Replace(conf.Database.URI)
-			hasURI = expandedURI != ""
-		}
-		if !hasURI && !conf.Database.Managed {
-			return nil, fmt.Errorf("%w: mssql engine requires database.uri to be set (ensure the environment variable is defined)", ErrDatabaseUnavailable)
+		if conf.Database.URI == "" && !conf.Database.Managed {
+			return nil, fmt.Errorf("mssql engine requires database.uri or database.managed")
 		}
 		c.databaseOnlyMode = true
 		// Create the MSSQL analyzer (implements Analyzer interface)

internal/compiler/errors.go

@@ -29,7 +29,6 @@ type Exec struct {
 	OS       []string          `json:"os"`
 	Env      map[string]string `json:"env"`
 	Meta     ExecMeta          `json:"meta"`
-	Requires []string          `json:"requires"` // Required databases: "postgres", "mysql", "mssql"
 }
 
 func parseStderr(t *testing.T, dir, testctx string) []byte {

internal/endtoend/case_test.go

@@ -101,9 +101,8 @@ func BenchmarkExamples(b *testing.B) {
 }
 
 type textContext struct {
-	Mutate             func(*testing.T, string) func(*config.Config)
-	Enabled            func() bool
-	AvailableDatabases map[string]bool // "postgres", "mysql", "mssql"
+	Mutate  func(*testing.T, string) func(*config.Config)
+	Enabled func() bool
 }
 
 func TestReplay(t *testing.T) {
@@ -192,17 +191,10 @@ func TestReplay(t *testing.T) {
 	t.Logf("MySQL available: %v (URI: %s)", mysqlURI != "", mysqlURI)
 	t.Logf("MSSQL available: %v (URI: %s)", mssqlURI != "", mssqlURI)
 
-	availableDatabases := map[string]bool{
-		"postgres": postgresURI != "",
-		"mysql":    mysqlURI != "",
-		"mssql":    mssqlURI != "",
-	}
-
 	contexts := map[string]textContext{
 		"base": {
-			Mutate:             func(t *testing.T, path string) func(*config.Config) { return func(c *config.Config) {} },
-			Enabled:            func() bool { return true },
-			AvailableDatabases: availableDatabases,
+			Mutate:  func(t *testing.T, path string) func(*config.Config) { return func(c *config.Config) {} },
+			Enabled: func() bool { return true },
 		},
 		"managed-db": {
 			Mutate: func(t *testing.T, path string) func(*config.Config) {
@@ -254,7 +246,6 @@ func TestReplay(t *testing.T) {
 				// Enabled if at least one database URI is available
 				return postgresURI != "" || mysqlURI != "" || mssqlURI != ""
 			},
-			AvailableDatabases: availableDatabases,
 		},
 	}
 
@@ -299,13 +290,6 @@ func TestReplay(t *testing.T) {
 					}
 				}
 
-				// Skip tests that require databases that are not available
-				for _, required := range args.Requires {
-					if !testctx.AvailableDatabases[required] {
-						t.Skipf("required database not available: %s", required)
-					}
-				}
-
 				opts := cmd.Options{
 					Env: cmd.Env{
 						Debug:      opts.DebugFromString(args.Env["SQLCDEBUG"]),