Avoid filenames with spaces in persist_uploaded_file

This makes it easier to use the file name in URLs without URL-encoding it.

fixes #668

Author: lovasoa

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fixed an incorrect warning polluting logs when using sqlpage functions with json arguments in sqlite: `WARN  sqlpage::webserver::database::execute_queries] The column _sqlpage_f0_a1 is missing from the result set, so it cannot be converted to JSON.`.
 - Fixed Microsoft SQL Server driver not being able to read VARCHAR columns from databases with non-european collations.
 - Added support for `BIT` columns in Microsoft SQL Server.
+- Avoid generating file names that contain spaces in `sqlpage.persist_uploaded_file`. This makes it easier to use the file name in URLs without URL-encoding it.
 
 ## 0.30.1 (2024-10-31)
 - fix a bug where table sorting would break if table search was not also enabled.

src/webserver/database/sqlpage_functions/functions.rs

@@ -311,9 +311,9 @@ async fn persist_uploaded_file<'a>(
     tokio::fs::create_dir_all(&target_folder)
         .await
         .with_context(|| format!("unable to create folder {target_folder:?}"))?;
-    let date = chrono::Utc::now().format("%Y-%m-%d %Hh%Mm%Ss");
+    let date = chrono::Utc::now().format("%Y-%m-%d_%Hh%Mm%Ss");
     let random_part = random_string_sync(8);
-    let random_target_name = format!("{date} {random_part}.{extension}");
+    let random_target_name = format!("{date}_{random_part}.{extension}");
     let target_path = target_folder.join(&random_target_name);
     tokio::fs::copy(&uploaded_file.file.path(), &target_path)
         .await