Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release compatible with Kotlin 2.0 #1489

Open
nreid260 opened this issue Jun 6, 2024 · 8 comments
Open

Release compatible with Kotlin 2.0 #1489

nreid260 opened this issue Jun 6, 2024 · 8 comments

Comments

@nreid260
Copy link
Contributor

nreid260 commented Jun 6, 2024

Is there an ETA for a Kotlin 2.0 compatible release?

I totally understand that kotlinc v2.0.0 only became available very recently!

@JakeWharton
Copy link
Collaborator

The existing release is compatible. Are you having problems?

@nreid260
Copy link
Contributor Author

Nope, seems to work! Very speedy.

We did have a bit of trouble with Timeout.cancel shadowing cancel from an outer class, but that's an us problem.

@nreid260
Copy link
Contributor Author

I spoke to soon #1490 seems to be needed

@nreid260 nreid260 reopened this Jun 13, 2024
@JakeWharton
Copy link
Collaborator

That's only needed for when we upgrade to build with Kotlin 2.0, right? The existing release remains compatible.

@nreid260
Copy link
Contributor Author

okio 3.9.0 is compatible with -language-mode=1.9, but we want to build with -language-mode=2.0

@JakeWharton
Copy link
Collaborator

Is there a reason you're building, as opposed to using our deployed artifacts?

@nreid260
Copy link
Contributor Author

We build from source as much as possible for security reasons. Also for Kotlin-native, we might be compiling for different architectures.

@JakeWharton
Copy link
Collaborator

Ah, I clicked your profile and I see now who "we" are and things are making sense. I, too, once suffered in the great monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants