Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Duplicate transactions with different category (Piraeus bank) #143

Open
GeorgeVarvates opened this issue Oct 11, 2022 · 10 comments
Open

Duplicate transactions with different category (Piraeus bank) #143

GeorgeVarvates opened this issue Oct 11, 2022 · 10 comments
Assignees
Labels
blocked This issue is blocked Bug Something isn't working - a bug stuck in the system! Medium Bug with medium priority

Comments

@GeorgeVarvates
Copy link

I have the following two transactions. Actually it' s the same transaction but it appears twice. Furthermore when i check the transactions' details i see that each transaction has a different transaction

image
Transaction 1 details
image

Transaction 2 details
image

@chris-iliopoulos chris-iliopoulos added Bug Something isn't working - a bug stuck in the system! Medium Bug with medium priority labels Oct 11, 2022
@stavrostheocharis
Copy link

@chris-iliopoulos I have 2 points here:

  1. Don't we visualize in FE only the account's side transactions? How can be seen the card side?

  2. What is happening with the category:
    This is actually similar to the other one: When do we consider a transaction as a recurring? #85
    Again here the above transactions have very different descriptions and based on our default similarity score they are considered different transactions.

So in detail in this case why do we have different categories? The two transactions are not considered the same. One comes from the account side and the other one comes from the card side. Based on the last one, they pass from different models for category classification and they get different categories (the account model, behaves differently than the cards model). Then since they are not considered and connected with the "duplicated_with" attribute they do not get a unified category. For this correction I 'll have again a look.

@chris-iliopoulos
Copy link
Collaborator

For clarification purposes: about your first point @stavrostheocharis in the GFM we show First the Accounts transactions, and Then the Cards transactions that DON'T have a duplicated with value (we consider these transactions to be the ones that our system hasn't got yet - the fresh transactions that only the bank has).

@stavrostheocharis
Copy link

Ahh ok nice, now I remember, thanks Chris. So, we will tackle it with the above correction.

@chris-iliopoulos chris-iliopoulos added the blocked This issue is blocked label Oct 24, 2022
@chris-iliopoulos
Copy link
Collaborator

@stavrostheocharis @sinnec do we have anything on this one? Is this still a thing or is it solved? Sorry, I didn't have any updates so it was forgotten...

@sinnec
Copy link

sinnec commented Mar 31, 2023

I'm pretty sure that this was worked on a long time ago, but we'll have to check again.

@chris-iliopoulos
Copy link
Collaborator

@GeorgeVarvates please tell me if you can re-test this case so we know if it's solved... thank u

@chris-iliopoulos
Copy link
Collaborator

chris-iliopoulos commented May 4, 2023

Screenshot 2023-05-04 at 17 34 38
Screenshot 2023-05-04 at 17 33 28

The same thing is happening to me due to the descriptions being different (for the same transaction) in the account and card transactions, respectively.

Will look more into it to see if we can do something about the descriptions' similarity check.

@sinnec @stavrostheocharis tagging you here... fyi

PS. don't mind the double '-' it's the card transaction's format, because this is isn't supposed to be visible

@chris-iliopoulos chris-iliopoulos self-assigned this May 5, 2023
@chris-iliopoulos
Copy link
Collaborator

@sinnec will this be fixed with the current WYRE version updates?

@sinnec
Copy link

sinnec commented May 16, 2023

It's ready and will be included in our next release!

@chris-iliopoulos
Copy link
Collaborator

@sinnec we still have some weird duplicate cases though, we should check them too.

Screenshot 2023-05-18 at 17 48 16

  1. The transaction with the negative amount is the one we (should) keep. This is the account transaction.
  2. Same for this one as the one above.
  3. This is an incoming transaction/refund through the debit card. The isDuplicatedWith flag should not be null (this is probably the different description's problem)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked This issue is blocked Bug Something isn't working - a bug stuck in the system! Medium Bug with medium priority
Projects
None yet
Development

No branches or pull requests

4 participants