Skip to content

Commit aabfc0b

Browse files
authored
Merge pull request #773 from erizocosmico/fix/oniguruma-not-default
do not build with oniguruma
2 parents fe8ac2b + ca58a36 commit aabfc0b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Package configuration
22
PROJECT = gitbase
33
COMMANDS = cmd/gitbase
4+
GO_BUILD_ARGS += -tags mysql_go_regex
45

56
# Including ci Makefile
67
CI_REPOSITORY ?= https://github.com/src-d/ci.git
@@ -32,7 +33,7 @@ static-package:
3233
# target used in the Dockerfile to build the static binary
3334
static-build: VERSION ?= $(shell git describe --exact-match --tags 2>/dev/null || "dev-$(git rev-parse --short HEAD)$(test -n "`git status --porcelain`" && echo "-dirty" || true)")
3435
static-build: LD_FLAGS += -linkmode external -extldflags '-static -lz' -s -w
35-
static-build: GO_BUILD_ARGS += -tags oniguruma
36+
static-build: GO_BUILD_ARGS += -tags mysql_go_regex
3637
static-build: GO_BUILD_PATH ?= github.com/src-d/gitbase/...
3738
static-build:
3839
go build -ldflags="$(LD_FLAGS)" -v $(GO_BUILD_ARGS) $(GO_BUILD_PATH)

docs/using-gitbase/getting-started.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ go get -u github.com/src-d/gitbase/...
4949

5050
#### Oniguruma support
5151

52-
**Note:** Oniguruma is enabled in the docker container and "static" linux binary.
53-
5452
On linux and macOS you can choose to build gitbase with oniguruma support, resulting in faster results for queries using the `language` UDF.
5553

5654
macOS:

0 commit comments

Comments
 (0)