Auto merge of servo#28663 - saschanaz:void-undefined, r=jdm

Convert Web IDL void to undefined

<!-- Please describe your changes on the following line: -->

Thanks to my tool https://github.com/saschanaz/gecko-webidl 🙌

Build is failing on my current VS2022+Python 3.10 environment, but the IDL tests are passing anyway, so...

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo#27660

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Author: bors-servo

components/script/dom/bindings/codegen/CodegenRust.py

@@ -1188,7 +1188,7 @@ def wrapObjectTemplate(templateBody, nullValue, isDefinitelyObject, type,
 
         return handleOptional(template, declType, handleDefault(empty))
 
-    if type.isVoid():
+    if type.isUndefined():
         # This one only happens for return values, and its easy: Just
         # ignore the jsval.
         return JSToNativeConversionInfo("", None, None)
@@ -1439,7 +1439,7 @@ def getConversionConfigForType(type, isEnforceRange, isClamp, treatNullAs):
 
 # Returns a CGThing containing the type of the return value.
 def getRetvalDeclarationForType(returnType, descriptorProvider):
-    if returnType is None or returnType.isVoid():
+    if returnType is None or returnType.isUndefined():
         # Nothing to declare
         return CGGeneric("()")
     if returnType.isPrimitive() and returnType.tag() in builtinNames:
@@ -4338,7 +4338,7 @@ def define(self):
                 result += self.defineJitInfo(setterinfo, setter, "Setter",
                                              False, False, "AliasEverything",
                                              False, False, "0",
-                                             [BuiltinTypes[IDLBuiltinType.Types.void]],
+                                             [BuiltinTypes[IDLBuiltinType.Types.undefined]],
                                              None)
             return result
         if self.member.isMethod():
@@ -4426,7 +4426,7 @@ def getJSReturnTypeTag(t):
         if t.nullable():
             # Sometimes it might return null, sometimes not
             return "JSVAL_TYPE_UNKNOWN"
-        if t.isVoid():
+        if t.isUndefined():
             # No return, every time
             return "JSVAL_TYPE_UNDEFINED"
         if t.isSequence():
@@ -4500,7 +4500,7 @@ def getSingleReturnType(existingType, t):
 
     @staticmethod
     def getJSArgType(t):
-        assert not t.isVoid()
+        assert not t.isUndefined()
         if t.nullable():
             # Sometimes it might return null, sometimes not
             return "JSJitInfo_ArgType::Null as i32 | %s" % CGMemberJITInfo.getJSArgType(t.inner)
@@ -7336,7 +7336,7 @@ def __init__(self, descriptorProvider, member, name, signature, extendedAttrs,
                              # Mark our getters, which are attrs that
                              # have a non-void return type, as const.
                              const=(not member.isStatic() and member.isAttr()
-                                    and not signature[0].isVoid()),
+                                    and not signature[0].isUndefined()),
                              breakAfterSelf=breakAfterSelf,
                              unsafe=unsafe,
                              visibility=visibility)
@@ -7608,7 +7608,7 @@ def getResultConversion(self):
         convertType = instantiateJSToNativeConversionTemplate(
             template, replacements, declType, "rvalDecl")
 
-        if self.retvalType is None or self.retvalType.isVoid():
+        if self.retvalType is None or self.retvalType.isUndefined():
             retval = "()"
         elif self.retvalType.isAny():
             retval = "rvalDecl.get()"

components/script/dom/bindings/codegen/parser/WebIDL.py

@@ -2093,7 +2093,7 @@ class IDLType(IDLObject):
         'utf8string',
         'jsstring',
         'object',
-        'void',
+        'undefined',
         # Funny stuff
         'interface',
         'dictionary',
@@ -2168,8 +2168,8 @@ def isUTF8String(self):
     def isJSString(self):
         return False
 
-    def isVoid(self):
-        return self.name == "Void"
+    def isUndefined(self):
+        return self.name == "Undefined"
 
     def isSequence(self):
         return False
@@ -2355,7 +2355,7 @@ def _getDependentObjects(self):
 
 class IDLNullableType(IDLParametrizedType):
     def __init__(self, location, innerType):
-        assert not innerType.isVoid()
+        assert not innerType.isUndefined()
         assert not innerType == BuiltinTypes[IDLBuiltinType.Types.any]
 
         IDLParametrizedType.__init__(self, location, None, innerType)
@@ -2414,7 +2414,7 @@ def isUnrestricted(self):
     def isInteger(self):
         return self.inner.isInteger()
 
-    def isVoid(self):
+    def isUndefined(self):
         return False
 
     def isSequence(self):
@@ -2517,7 +2517,7 @@ def withExtendedAttributes(self, attrs):
 
 class IDLSequenceType(IDLParametrizedType):
     def __init__(self, location, parameterType):
-        assert not parameterType.isVoid()
+        assert not parameterType.isUndefined()
 
         IDLParametrizedType.__init__(self, location, parameterType.name, parameterType)
         # Need to set self.name up front if our inner type is already complete,
@@ -2561,7 +2561,7 @@ def isUTF8String(self):
     def isJSString(self):
         return False
 
-    def isVoid(self):
+    def isUndefined(self):
         return False
 
     def isSequence(self):
@@ -2602,7 +2602,7 @@ class IDLRecordType(IDLParametrizedType):
     def __init__(self, location, keyType, valueType):
         assert keyType.isString()
         assert keyType.isComplete()
-        assert not valueType.isVoid()
+        assert not valueType.isUndefined()
 
         IDLParametrizedType.__init__(self, location, valueType.name, valueType)
         self.keyType = keyType
@@ -2673,7 +2673,7 @@ def __hash__(self):
     def prettyName(self):
         return "(" + " or ".join(m.prettyName() for m in self.memberTypes) + ")"
 
-    def isVoid(self):
+    def isUndefined(self):
         return False
 
     def isUnion(self):
@@ -2836,8 +2836,8 @@ def isUTF8String(self):
     def isJSString(self):
         return self.inner.isJSString()
 
-    def isVoid(self):
-        return self.inner.isVoid()
+    def isUndefined(self):
+        return self.inner.isUndefined()
 
     def isJSONType(self):
         return self.inner.isJSONType()
@@ -2972,7 +2972,7 @@ def isUTF8String(self):
     def isJSString(self):
         return False
 
-    def isVoid(self):
+    def isUndefined(self):
         return False
 
     def isSequence(self):
@@ -3178,7 +3178,7 @@ class IDLBuiltinType(IDLType):
         'utf8string',
         'jsstring',
         'object',
-        'void',
+        'undefined',
         # Funny stuff
         'ArrayBuffer',
         'ArrayBufferView',
@@ -3215,7 +3215,7 @@ class IDLBuiltinType(IDLType):
         Types.utf8string: IDLType.Tags.utf8string,
         Types.jsstring: IDLType.Tags.jsstring,
         Types.object: IDLType.Tags.object,
-        Types.void: IDLType.Tags.void,
+        Types.undefined: IDLType.Tags.undefined,
         Types.ArrayBuffer: IDLType.Tags.interface,
         Types.ArrayBufferView: IDLType.Tags.interface,
         Types.Int8Array: IDLType.Tags.interface,
@@ -3251,7 +3251,7 @@ class IDLBuiltinType(IDLType):
         Types.utf8string: "USVString", # That's what it is in spec terms
         Types.jsstring: "USVString", # Again, that's what it is in spec terms
         Types.object: "object",
-        Types.void: "void",
+        Types.undefined: "undefined",
         Types.ArrayBuffer: "ArrayBuffer",
         Types.ArrayBufferView: "ArrayBufferView",
         Types.Int8Array: "Int8Array",
@@ -3456,8 +3456,8 @@ def isDistinguishableFrom(self, other):
             return False
         if self.isObject():
             return other.isPrimitive() or other.isString() or other.isEnum()
-        if self.isVoid():
-            return not other.isVoid()
+        if self.isUndefined():
+            return not other.isUndefined()
         # Not much else we could be!
         assert self.isSpiderMonkeyInterface()
         # Like interfaces, but we know we're not a callback
@@ -3591,9 +3591,9 @@ def withExtendedAttributes(self, attrs):
     IDLBuiltinType.Types.object:
         IDLBuiltinType(BuiltinLocation("<builtin type>"), "Object",
                        IDLBuiltinType.Types.object),
-    IDLBuiltinType.Types.void:
-        IDLBuiltinType(BuiltinLocation("<builtin type>"), "Void",
-                       IDLBuiltinType.Types.void),
+    IDLBuiltinType.Types.undefined:
+        IDLBuiltinType(BuiltinLocation("<builtin type>"), "Undefined",
+                       IDLBuiltinType.Types.undefined),
     IDLBuiltinType.Types.ArrayBuffer:
         IDLBuiltinType(BuiltinLocation("<builtin type>"), "ArrayBuffer",
                        IDLBuiltinType.Types.ArrayBuffer),
@@ -4196,9 +4196,9 @@ def expand(self, members, isJSImplemented):
         self.addMethod("values", members, False, self.iteratorType,
                        affectsNothing=True, newObject=True)
 
-        # void forEach(callback(valueType, keyType), optional any thisArg)
+        # undefined forEach(callback(valueType, keyType), optional any thisArg)
         self.addMethod("forEach", members, False,
-                       BuiltinTypes[IDLBuiltinType.Types.void],
+                       BuiltinTypes[IDLBuiltinType.Types.undefined],
                        self.getForEachArguments())
 
     def isValueIterator(self):
@@ -4256,8 +4256,8 @@ def expand(self, members, isJSImplemented):
         self.addMethod("values", members, False, BuiltinTypes[IDLBuiltinType.Types.object],
                        affectsNothing=True, isIteratorAlias=self.isSetlike())
 
-        # void forEach(callback(valueType, keyType), thisVal)
-        self.addMethod("forEach", members, False, BuiltinTypes[IDLBuiltinType.Types.void],
+        # undefined forEach(callback(valueType, keyType), thisVal)
+        self.addMethod("forEach", members, False, BuiltinTypes[IDLBuiltinType.Types.undefined],
                        self.getForEachArguments())
 
         def getKeyArg():
@@ -4270,8 +4270,8 @@ def getKeyArg():
                        [getKeyArg()], isPure=True)
 
         if not self.readonly:
-            # void clear()
-            self.addMethod("clear", members, True, BuiltinTypes[IDLBuiltinType.Types.void],
+            # undefined clear()
+            self.addMethod("clear", members, True, BuiltinTypes[IDLBuiltinType.Types.undefined],
                            [])
             # boolean delete(keyType key)
             self.addMethod("delete", members, True,
@@ -4280,8 +4280,8 @@ def getKeyArg():
         # Always generate underscored functions (e.g. __add, __clear) for js
         # implemented interfaces as convenience functions.
         if isJSImplemented:
-            # void clear()
-            self.addMethod("clear", members, True, BuiltinTypes[IDLBuiltinType.Types.void],
+            # undefined clear()
+            self.addMethod("clear", members, True, BuiltinTypes[IDLBuiltinType.Types.undefined],
                            [], chromeOnly=True)
             # boolean delete(keyType key)
             self.addMethod("delete", members, True,
@@ -5119,7 +5119,7 @@ def assertSignatureConstraints(self):
             assert (arguments[0].type == BuiltinTypes[IDLBuiltinType.Types.domstring] or
                     arguments[0].type == BuiltinTypes[IDLBuiltinType.Types.unsigned_long])
             assert not arguments[0].optional and not arguments[0].variadic
-            assert not self._getter or not overload.returnType.isVoid()
+            assert not self._getter or not overload.returnType.isUndefined()
 
         if self._setter:
             assert len(self._overloads) == 1
@@ -5480,8 +5480,8 @@ def handleExtendedAttribute(self, attr):
             # This is called before we've done overload resolution
             overloads = self._overloads
             assert len(overloads) == 1
-            if not overloads[0].returnType.isVoid():
-                raise WebIDLError("[LenientFloat] used on a non-void method",
+            if not overloads[0].returnType.isUndefined():
+                raise WebIDLError("[LenientFloat] used on a non-undefined returning method",
                                   [attr.location, self.location])
             if not overloads[0].includesRestrictedFloatArgument():
                 raise WebIDLError("[LenientFloat] used on an operation with no "
@@ -5837,7 +5837,7 @@ def t_OTHER(self, t):
         "record": "RECORD",
         "short": "SHORT",
         "unsigned": "UNSIGNED",
-        "void": "VOID",
+        "undefined": "UNDEFINED",
         ":": "COLON",
         ";": "SEMICOLON",
         "{": "LBRACE",
@@ -6722,8 +6722,8 @@ def p_Operation(self, p):
                                    "optional" if arguments[0].optional else "variadic"),
                                   [arguments[0].location])
         if getter:
-            if returnType.isVoid():
-                raise WebIDLError("getter cannot have void return type",
+            if returnType.isUndefined():
+                raise WebIDLError("getter cannot have undefined return type",
                                   [self.getLocation(p, 2)])
         if setter:
             if len(arguments) != 2:
@@ -7103,7 +7103,7 @@ def p_Other(self, p):
                   | SYMBOL
                   | TRUE
                   | UNSIGNED
-                  | VOID
+                  | UNDEFINED
                   | ArgumentNameKeyword
         """
         pass
@@ -7145,7 +7145,7 @@ def p_SingleTypeAnyType(self, p):
         """
         p[0] = BuiltinTypes[IDLBuiltinType.Types.any]
 
-    # Note: Promise<void> is allowed, so we want to parametrize on ReturnType,
+    # Note: Promise<undefined> is allowed, so we want to parametrize on ReturnType,
     # not Type.  Promise types can't be null, hence no "Null" in there.
     def p_SingleTypePromiseType(self, p):
         """
@@ -7413,11 +7413,11 @@ def p_ReturnTypeType(self, p):
         """
         p[0] = p[1]
 
-    def p_ReturnTypeVoid(self, p):
+    def p_ReturnTypeUndefined(self, p):
         """
-            ReturnType : VOID
+            ReturnType : UNDEFINED
         """
-        p[0] = BuiltinTypes[IDLBuiltinType.Types.void]
+        p[0] = BuiltinTypes[IDLBuiltinType.Types.undefined]
 
     def p_ScopedName(self, p):
         """

components/script/dom/bindings/codegen/parser/tests/test_argument_identifier_conflicts.py

@@ -3,7 +3,7 @@ def WebIDLTest(parser, harness):
     try:
         parser.parse("""
             interface ArgumentIdentifierConflict {
-              void foo(boolean arg1, boolean arg1);
+              undefined foo(boolean arg1, boolean arg1);
             };
         """)
 

components/script/dom/bindings/codegen/parser/tests/test_argument_keywords.py

@@ -1,7 +1,7 @@
 def WebIDLTest(parser, harness):
     parser.parse("""
     interface Foo {
-      void foo(object constructor);
+      undefined foo(object constructor);
     };
     """)
 

components/script/dom/bindings/codegen/parser/tests/test_argument_novoid.py

@@ -2,8 +2,8 @@ def WebIDLTest(parser, harness):
     threw = False
     try:
         parser.parse("""
-            interface VoidArgument1 {
-              void foo(void arg2);
+            interface UndefinedArgument1 {
+              undefined foo(undefined arg2);
             };
         """)