Merge pull request #15 from izumin5210/izumin5210/map

Map status code only when grpc/codes.Code has not been set

Author: izumin5210

handlers.go

@@ -100,7 +100,9 @@ func WithStatusCodeMap(m map[int]codes.Code) interface {
 } {
 	return WithAppErrorHandler(func(c context.Context, err *apperrors.Error) error {
 		newCode := codes.Unknown
-		if c, ok := m[err.StatusCode]; ok {
+		if s, ok := status.FromError(err.Err); ok {
+			newCode = s.Code()
+		} else if c, ok := m[err.StatusCode]; ok {
 			newCode = c
 		}
 		return status.Error(newCode, err.Error())

interceptors_test.go

@@ -52,6 +52,14 @@ func (s *errorWithStatusService) EmptyCall(context.Context, *errorstesting.Empty
 	return nil, apperrors.WithStatusCode(errors.New("This error has a status code"), s.Code)
 }
 
+type errorWithGrpcStatusService struct {
+	Code codes.Code
+}
+
+func (s *errorWithGrpcStatusService) EmptyCall(context.Context, *errorstesting.Empty) (*errorstesting.Empty, error) {
+	return nil, apperrors.Wrap(status.Error(s.Code, "This error has a gRPC status code"))
+}
+
 // Testings
 // ================================================
 func Test_UnaryServerInterceptor_WhenDoesNotRespondErrors(t *testing.T) {
@@ -279,6 +287,38 @@ func Test_UnaryServerInterceptor_WithStatusCodeMap_WhenUnknownCode(t *testing.T)
 	}
 }
 
+func Test_UnaryServerInterceptor_WithStatusCodeMap_WhenAlreadySet(t *testing.T) {
+	code := codes.Unauthenticated
+
+	ctx := errorstesting.CreateTestContext(t)
+	ctx.Service = &errorWithGrpcStatusService{Code: code}
+	ctx.AddUnaryServerInterceptor(
+		UnaryServerInterceptor(
+			WithStatusCodeMap(map[int]codes.Code{
+				int(code): codes.Aborted,
+			}),
+		),
+	)
+	ctx.Setup()
+	defer ctx.Teardown()
+
+	resp, err := ctx.Client.EmptyCall(context.Background(), &errorstesting.Empty{})
+
+	if resp != nil {
+		t.Error("The request should not return any responses")
+	}
+
+	if err == nil {
+		t.Error("The request should return an error")
+	}
+
+	if st, ok := status.FromError(err); !ok {
+		t.Error("Returned error should has status code")
+	} else if got, want := st.Code(), code; got != want {
+		t.Errorf("Returned error had status code %v, want %v", got, want)
+	}
+}
+
 func Test_UnaryServerInterceptor_WithStatusCodeMapper(t *testing.T) {
 	code := 50
 	mappedCode := codes.Unavailable