33 workflow_call :
44 inputs :
55 product-name :
6+ description : The boil product directory name (e.g. "hadoop" or "precompiled/hadoop")
67 required : true
78 type : string
9+ image-name :
10+ description : |
11+ The image name used in the OCI registry. Defaults to product-name if not set.
12+ This is used when the boil directory is nested (eg: precompiled/hadoop) but
13+ the parent directory will be used as the namespace (eg: precompiled).
14+ default : " "
15+ type : string
816 sdp-version :
917 required : true
1018 type : string
@@ -112,10 +120,14 @@ jobs:
112120 image-registry-uri : oci.stackable.tech
113121 image-registry-username : robot$${{ inputs.registry-namespace }}+github-action-build
114122 image-registry-password : ${{ secrets.harbor-robot-secret }}
115- image-repository : ${{ inputs.registry-namespace }}/${{ inputs.product-name }}
123+ # NOTE (@NickLarsenNZ): This fallback is just for now so we can support both repo level
124+ # image folders that go under the sdp namespace AND nested image folders that contain the
125+ # namespace (for example precommit/hadoop).
126+ # In future, we probably want to encode this information in the boil config metadata per
127+ # registry so we don't have to do such gymnastics in the workflow.
128+ image-repository : ${{ inputs.registry-namespace }}/${{ inputs.image-name || inputs.product-name }}
116129 image-manifest-tag : ${{ steps.build.outputs.image-manifest-tag }}
117130 source-image-uri : localhost/${{ inputs.registry-namespace }}/${{ inputs.product-name }}:${{ steps.build.outputs.image-manifest-tag }}
118-
119131 publish_manifests :
120132 name : Build/Publish ${{ matrix.versions }} Manifests
121133 needs : [generate_version_dimension, build]
@@ -139,7 +151,12 @@ jobs:
139151 image-registry-uri : oci.stackable.tech
140152 image-registry-username : robot$${{ inputs.registry-namespace }}+github-action-build
141153 image-registry-password : ${{ secrets.harbor-robot-secret }}
142- image-repository : ${{ inputs.registry-namespace }}/${{ inputs.product-name }}
154+ # NOTE (@NickLarsenNZ): This fallback is just for now so we can support both repo level
155+ # image folders that go under the sdp namespace AND nested image folders that contain the
156+ # namespace (for example precommit/hadoop).
157+ # In future, we probably want to encode this information in the boil config metadata per
158+ # registry so we don't have to do such gymnastics in the workflow.
159+ image-repository : ${{ inputs.registry-namespace }}/${{ inputs.image-name || inputs.product-name }}
143160 image-index-manifest-tag : ${{ matrix.versions }}-stackable${{ inputs.sdp-version }}
144161
145162 notify :
0 commit comments