Fix lints in new code

Author: sbernauer

crates/stackable-operator/src/config_overrides.rs

@@ -105,12 +105,12 @@ impl JsonConfigOverrides {
     /// entirely and the user-provided string is parsed and returned.
     pub fn apply(&self, base: &serde_json::Value) -> Result<serde_json::Value, Error> {
         match self {
-            JsonConfigOverrides::JsonMergePatch(patch) => {
+            Self::JsonMergePatch(patch) => {
                 let mut doc = base.clone();
                 json_patch::merge(&mut doc, patch);
                 Ok(doc)
             }
-            JsonConfigOverrides::JsonPatches(patches) => {
+            Self::JsonPatches(patches) => {
                 let mut doc = base.clone();
                 let operations: Vec<json_patch::PatchOperation> = patches
                     .iter()
@@ -123,7 +123,7 @@ impl JsonConfigOverrides {
                 json_patch::patch(&mut doc, &operations).context(ApplyJsonPatchSnafu)?;
                 Ok(doc)
             }
-            JsonConfigOverrides::UserProvided(content) => {
+            Self::UserProvided(content) => {
                 serde_json::from_str(content).context(ParseUserProvidedJsonSnafu)
             }
         }

crates/stackable-operator/src/database_connections/databases/derby.rs

@@ -31,7 +31,7 @@ pub enum Error {
 /// Derby is an embedded, file-based Java database engine that requires no separate server process.
 /// It is typically used for development, testing, or as a lightweight metastore backend (e.g. for
 /// Apache Hive).
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct DerbyConnection {
     /// Path on the filesystem where Derby stores its database files.

crates/stackable-operator/src/database_connections/databases/mysql.rs

@@ -20,7 +20,7 @@ pub enum Error {
 }
 
 /// Connection settings for a [MySQL](https://www.mysql.com/) database.
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct MysqlConnection {
     /// Hostname or IP address of the MySQL server.

crates/stackable-operator/src/database_connections/databases/postgresql.rs

@@ -26,7 +26,7 @@ pub enum Error {
 }
 
 /// Connection settings for a [PostgreSQL](https://www.postgresql.org/) database.
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct PostgresqlConnection {
     /// Hostname or IP address of the PostgreSQL server.

crates/stackable-operator/src/database_connections/databases/redis.rs

@@ -13,7 +13,7 @@ use crate::{
 /// Connection settings for a [Redis](https://redis.io/) instance.
 ///
 /// Redis is commonly used as a Celery message broker or result backend (e.g. for Apache Airflow).
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct RedisConnection {
     /// Hostname or IP address of the Redis server.

crates/stackable-operator/src/database_connections/drivers/celery.rs

@@ -83,7 +83,7 @@ impl CeleryDatabaseConnectionDetails {
 /// Use this when you need a Celery-compatible connection that does not have a first-class
 /// connection type. The complete connection URL is read from a Secret, giving the user full
 /// control over the connection string.
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct GenericCeleryDatabaseConnection {
     /// The name of the Secret that contains an `connectionUrl` key with the complete Celery URL.

crates/stackable-operator/src/database_connections/drivers/jdbc.rs

@@ -71,7 +71,7 @@ impl JdbcDatabaseConnectionDetails {
 /// Use this when you need to connect to a JDBC-compatible database that does not have a
 /// first-class connection type. You are responsible for providing the correct driver class name
 /// and a fully-formed JDBC URL as well as providing the needed classes on the Java classpath.
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct GenericJdbcDatabaseConnection {
     /// Fully-qualified Java class name of the JDBC driver, e.g. `org.postgresql.Driver` or

crates/stackable-operator/src/database_connections/drivers/sqlalchemy.rs

@@ -82,7 +82,7 @@ impl SqlAlchemyDatabaseConnectionDetails {
 /// Use this when you need to connect to a SQLAlchemy-compatible database that does not have a
 /// first-class connection type. The complete connection URL is read from a Secret, giving the user
 /// full control over the connection string including any driver-specific options.
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct GenericSqlAlchemyDatabaseConnection {
     /// The name of the Secret that contains an `connectionUrl` key with the complete SQLAlchemy URL.

crates/stackable-operator/src/product_config_utils.rs

@@ -718,7 +718,7 @@ mod tests {
         fn get_key_value_overrides(&self, file: &str) -> BTreeMap<String, Option<String>> {
             self.files
                 .get(file)
-                .map(|kv| kv.as_product_config_overrides())
+                .map(KeyValueConfigOverrides::as_product_config_overrides)
                 .unwrap_or_default()
         }
     }

crates/xtask/src/crd/dummy.rs

@@ -56,7 +56,7 @@ impl KeyValueOverridesProvider for DummyConfigOverrides {
             "dummy.properties" => self
                 .dummy_properties
                 .as_ref()
-                .map(|o| o.as_product_config_overrides())
+                .map(KeyValueConfigOverrides::as_product_config_overrides)
                 .unwrap_or_default(),
             _ => BTreeMap::new(),
         }
@@ -162,7 +162,7 @@ pub mod versioned {
         UserInfoFetcher,
     }
 
-    #[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+    #[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
     #[serde(rename_all = "camelCase")]
     #[schemars(crate = "stackable_operator::schemars")]
     pub enum DummyDatabaseConnection {