explain why serialization statement won't fail

Author: labrenbe

rust/stackable-cockpit/src/platform/operator/mod.rs

@@ -225,7 +225,7 @@ impl OperatorSpec {
         let helm_values_yaml = if helm_values.is_empty() {
             None
         } else {
-            Some(serde_yaml::to_string(&helm_values).expect("Value serialization should not fail"))
+            Some(serde_yaml::to_string(&helm_values).expect("serializing a small YAML Mapping back to a YAML string can't fail"))
         };
 
         // Install using Helm

rust/stackablectl/src/utils.rs

@@ -13,15 +13,14 @@ use crate::constants::{HELM_REPO_URL_DEV, HELM_REPO_URL_STABLE, HELM_REPO_URL_TE
 #[derive(Debug, Snafu)]
 pub enum Error {
     #[snafu(display("failed to open or transfer values file '{path}'"))]
-    FileTransfer {
-        source: xfer::Error,
-        path: String,
-    },
+    FileTransfer { source: xfer::Error, path: String },
 
     #[snafu(display("operator values file '{path}' must be a YAML mapping at the top level"))]
     InvalidValueType { path: String },
 
-    #[snafu(display("value for key '{key}' in operator values file '{path}' must be a YAML mapping"))]
+    #[snafu(display(
+        "value for key '{key}' in operator values file '{path}' must be a YAML mapping"
+    ))]
     InvalidEntryType { key: String, path: String },
 }
 
@@ -95,12 +94,7 @@ pub async fn load_operator_values(
 
     let mapping = match value {
         Value::Mapping(mapping) => mapping,
-        _ => {
-            return InvalidValueTypeSnafu {
-                path: path.clone(),
-            }
-            .fail()
-        }
+        _ => return InvalidValueTypeSnafu { path: path.clone() }.fail(),
     };
 
     for (key, value) in &mapping {