Skip to content

Commit 2a8cfa8

Browse files
committed
fix ansible-lint whinging
1 parent 0d372fb commit 2a8cfa8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

tasks/runtime.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
when: openhpc_slurm_service_started | bool
166166

167167
- name: Check slurmdbd state
168-
command: systemctl is-active slurmdbd
168+
command: systemctl is-active slurmdbd # noqa: command-instead-of-module
169169
changed_when: false
170170
failed_when: false # rc = 0 when active
171171
register: _openhpc_slurmdbd_state

tasks/upgrade.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,11 @@
4747
- openhpc_slurm_accounting_storage_service != ''
4848

4949
- name: Backup Slurm database
50-
ansible.builtin.shell:
50+
ansible.builtin.shell: # noqa: command-instead-of-shell
5151
cmd: "{{ openhpc_slurm_accounting_storage_backup_cmd }}"
5252
delegate_to: "{{ openhpc_slurm_accounting_storage_backup_host }}"
5353
become: "{{ openhpc_slurm_accounting_storage_backup_become }}"
54+
changed_when: true # limt no-changed-when
5455
run_once: true
5556
when:
5657
- _openhpc_slurmdb_upgrade
@@ -72,5 +73,6 @@
7273
# See https://wiki.fysik.dtu.dk/Niflheim_system/Slurm_installation/#upgrade-slurmdbd
7374
# and
7475
# https://github.com/SchedMD/slurm/blob/0ce058c5adcf63001ec2ad211c65e67b0e7682a8/src/plugins/accounting_storage/mysql/as_mysql_usage.c#L1042
76+
become: true
7577
become_user: slurm
7678
when: _openhpc_slurmdb_upgrade

0 commit comments

Comments
 (0)