Skip to content

Unable to add extra slurm.conf items with the same key #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tom91136 opened this issue Jun 15, 2024 · 3 comments
Open

Unable to add extra slurm.conf items with the same key #169

tom91136 opened this issue Jun 15, 2024 · 3 comments

Comments

@tom91136
Copy link

We're using this playbook to setup a Warewulf managed system so the compute nodes will not be available (images are not created yet so can't boot).
The current play tolerates empty host groups but we can't inject computes nodes with known configurations because openhpc_config expects a dictionary:

      openhpc_config:
        NodeName: "compute1 CPU=1 State=UNKNOWN"
        NodeName: "compute0 CPU=1 State=UNKNOWN" # duplicate key

Looking at the slurm.conf syntax, I think using a list will be more appropriate here.

@tom91136
Copy link
Author

For backwards compatibility, we can check if openhpc_config is a string or list and append the content (one line per list item or the entire string as-is) at the end of the slurm.conf template for maximum flexibility.

@tom91136
Copy link
Author

Happy to open a PR if welcomed.

@sjpb
Copy link
Collaborator

sjpb commented May 15, 2025

Don't really want to go down that route. The openhpc_config parameter is really for unique parameters, not for defining nodes/partitions or other things which occur multiple times.

Autotedection of node config is a pretty major feature of the role, so if you're using it in a way where that is not the case its probably better to replace the whole slurm.conf.j2 template. Will have a think about this for follow-on changes after #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants