-
Notifications
You must be signed in to change notification settings - Fork 23
Updating policy for neutron and nova to include role: baremetaluser #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Neutron and Nova policies to grant the baremetaluser role additional permissions, aligning with the goal of simplifying baremetal instance management. The changes in the Nova policy file are clear and correct. For the Neutron policy file, I've suggested a minor improvement to enhance readability and prevent potential issues by explicitly grouping and conditions with parentheses. Overall, the changes look good and address the intended purpose.
ac479a1 to
caaca7d
Compare
72e75ba to
084d9ff
Compare
But the alternative is users bricking the cloud using the admin role? I didn't know the policy didn't merge. Given people have overrides that is a very good reason for this to not be the default. Supporting policy.d makes very good sense as something for the backlog. Is a mix-in for now a better middle ground for now? |
Updating policy to allow role: baremetaluser to map baremetal instances to specific ironic nodes (this is desirable so that the instance name = ironic node name, making debugging less confusing)