Skip to content

Conversation

@claudia-lola
Copy link

Updating policy to allow role: baremetaluser to map baremetal instances to specific ironic nodes (this is desirable so that the instance name = ironic node name, making debugging less confusing)

@claudia-lola claudia-lola self-assigned this Sep 26, 2025
@claudia-lola claudia-lola requested a review from a team as a code owner September 26, 2025 16:21
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Neutron and Nova policies to grant the baremetaluser role additional permissions, aligning with the goal of simplifying baremetal instance management. The changes in the Nova policy file are clear and correct. For the Neutron policy file, I've suggested a minor improvement to enhance readability and prevent potential issues by explicitly grouping and conditions with parentheses. Overall, the changes look good and address the intended purpose.

@claudia-lola claudia-lola force-pushed the claudia-baremetaluser branch 2 times, most recently from 72e75ba to 084d9ff Compare September 29, 2025 13:45
@JohnGarbutt
Copy link
Member

JohnGarbutt commented Nov 13, 2025

So first of all - it can't be the default.
Second of all - we don't have support for merging policy.yaml files together - so I would say before that lands - we need to work on the kolla-ansible side to add support for either policy.d (which would be ideal) - or merging policy.yaml files together and validating them?

But the alternative is users bricking the cloud using the admin role?

I didn't know the policy didn't merge. Given people have overrides that is a very good reason for this to not be the default. Supporting policy.d makes very good sense as something for the backlog.

Is a mix-in for now a better middle ground for now?

@JohnGarbutt JohnGarbutt reopened this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants