-
Notifications
You must be signed in to change notification settings - Fork 23
Add secret store unseal playbook for action runners #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Ansible playbook for unsealing the secret store on CI action runners, which is a necessary step after they are rebooted. The playbook is clear and follows existing patterns within the project. My review includes a couple of suggestions to improve maintainability and idempotency. One suggestion is to change the pip package state from latest to present to ensure predictable behavior. The other is a recommendation to refactor common tasks into a shared role to avoid code duplication with other similar playbooks.
Alex-Welsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a reno
Given how similar this and the other secret-store-unseal-*.yml playbooks are, we should probably just extend the vault_unseal role to reduce duplication a bit.
That's scope creep though, and I'm happy to do it this way for now.
When CI action runners are rebooted, their secret store needs to be unsealed. Added unsealing playbook for them.
1e33d76 to
6cfde3e
Compare
Alex-Welsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more general thought, should we just run this every time we trigger CI?
releasenotes/notes/add-secret-store-unseal-playbook-for-ci-runners-ec758e93a8984760.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Welsh <[email protected]>
|
I don't know... Maybe? |
|
Well even if we want to run this every time we run CI, I think that needs to be done via separate PR. |
When CI action runners are rebooted, their secret store needs to be unsealed.
Added unsealing playbook for them.