Update toolhive to v0.23.1 (manual dispatch) - #780
Closed
github-actions[bot] wants to merge 3 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
ChrisJBurns,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
April 22, 2026 08:59
Contributor
Author
|
Claude Opus is generating docs updates for (This comment replaces the real-time tracking comment claude-code-action posts on Renovate-opened PRs, which isn't supported on |
Update all v1alpha1 apiVersion references in docs to v1beta1 to reflect the API graduation in toolhive v0.23.0. Expand the migration guide with a v0.23.0 section covering the graduation and the recommended manifest update path.
Contributor
Author
Upstream-release-docs run summaryProject:
Full report and Claude's step-by-step log: https://github.com/stacklok/docs-website/actions/runs/24769641826 |
rdimitrov
added a commit
that referenced
this pull request
Apr 22, 2026
* Record per-skill turns/cost and surface in PR body + summary Adds two capture steps that parse claude-code-action's execution log (`/home/runner/work/_temp/claude-execution-output.json`) right after each skill invocation, BEFORE the next one overwrites the shared file. Exposes `turns`, `cost_usd`, and `permission_denials` as step outputs for downstream use. Surfaces the data in two places: 1. PR body: new "Run cost" subsection inside the upstream-release- docs marker block. Per-session rows plus a Total row when both sessions reported. Applies to both pull_request and workflow_dispatch runs. 2. workflow_dispatch summary comment: adds Turns and Cost columns to the existing step table, plus a Total row summing both sessions. Useful for tracking per-release spend ($6 baseline) and catching regressions -- e.g. a release that suddenly takes 10x the turns is visible at a glance rather than requiring a drill-down into the Actions Step Summary. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Reorganise PR body and comments for scannability Ground-up redesign of everything the workflow posts on a PR. Previous output read as three authors writing on the same page (log formatter + release notes + systems docs), with no visual hierarchy and a lot of process lore competing with actionable info. Feedback after PRs #779 and #780. Key structural shift: the PR body is the single source of truth for state. Comments are point-in-time events only. Process lore goes behind <details>. Changes: **PR body** (rewritten end-to-end) - New H2: "Docs update for <project> <tag>" replaces the process-descriptive "Content additions by upstream-release-docs". - New "At a glance" table with 6 rows: Upstream (linked compare), Hand-written changes, Reference assets, Gaps, Release contributors, Action required. Answers the 5 questions a reviewer actually asks in < 5 seconds. - Single top-of-section alert (at most one), ordered by severity: CAUTION for autogen-path drift, NOTE for NO_CHANGES.md, NOTE for silent run. Never stacked. - Autogen drift promoted from inline [!WARNING] paragraph to [!CAUTION] at the top with a bulleted revert list -- it's a merge-blocker, should look like one. - "Review guidance" paragraph deleted. The one operational claim ("reference files are auto-synced") is in the At-a-glance "Reference assets" row. - "Release contributors" section dropped when everyone got auto-assigned (GitHub's sidebar already shows them). Only rendered as "Additional release contributors" when overflow @-mentions need a target. - "Run cost" table kept visible, not buried in <details>, per request. - Process narrative ("Two Claude Opus sessions...", auto-synced paths, Helper-prompt convention) collapsed into a single <details> block at the bottom. - Compare-failure warning moved from a top-of-section [!WARNING] block into the At-a-glance "Release contributors" cell. **Bootstrap PR body** - Collapsed from two paragraphs to one line ("Manually dispatched by @x. Workflow run: ..."). Mechanism narration deleted. **Pre-skill placeholder comment** (workflow_dispatch only) - From a two-paragraph explanation + parenthetical meta-note ("this comment exists because track_progress isn't supported on workflow_dispatch") to a single line: "Generating docs for <project> <tag>... (run)". **Post-skill summary comment** (workflow_dispatch only) - Table replaced with a one-line status: "Done · 93 turns · $6.04 · run · see PR body for details". On failure, identifies which step died. Duplicative detail (conclusions, commit counts) was already in the PR body. - Dropped "Skill commits produced" row -- the at-a-glance "Hand-written changes" cell covers it. **Augmentation failure comment** - Wrapped in [!CAUTION] alert, compressed to two lines with the exact retry gh command inline (not a hand-wavy "retry via the workflow" pointer). **Autogen-touch step (`detect-autogen`)** - Now emits `touched` output (comma-separated paths) directly instead of pre-formatting a warning block. The Augment step composes the alert itself. Cleaner separation of concerns. Unchanged: reviewer assignment logic, skill prompts, autofix step, concurrency config. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rdimitrov
added a commit
that referenced
this pull request
Apr 22, 2026
* Add turn/timeout caps and sync local HEAD after skill pushes Three defensive additions to the upstream-release-docs pipeline. ## Sync local HEAD with skill-pushed commits claude-code-action works in a sibling scratch checkout (the `.claude-pr/` dir we gitignore) and pushes its commits to origin without advancing the outer workflow checkout's HEAD. Every subsequent step that reads local git state saw stale HEAD at the pre-skill SHA. Symptoms on PR #780: - `skill_commits` counter reported 0 despite commit `d4b3c7c` existing on the PR branch -- triggered the silent-run NOTE on a run that wasn't actually silent. - `autofix` early-exited with "No skill-touched files in scope" because its `git diff BASELINE_SHA..HEAD` returned nothing. 41 unformatted files from the skill landed on CI and failed the Lint and format checks job. Fix: new step between `skill_review` and `skill_commits` that runs `git fetch origin $HEAD_REF && git merge --ff-only`. Local HEAD now reflects whatever the skill pushed, so downstream steps see the truth. ## --max-turns caps Per-session turn ceilings via claude_args: - skill_gen: 500 (baselines: 89 silent → 397 full rebuild) - skill_review: 30 (baseline: 4-5 turns every run) Clips genuine runaway loops without interfering with legitimate complex runs. Hitting a cap fails loudly; we raise deliberately if a release genuinely needs more. ## timeout-minutes per step Wall-clock ceilings: - skill_gen: 45 min (observed: 15-22 min) - skill_review: 10 min (observed: 1-2 min) Kills a stuck process before it burns the full 90-min job budget. ## What this does NOT cover - Legitimate-but-expensive runs (PR #780 at $27 is real work). - Upstream Anthropic pricing changes. - High-frequency workflow triggering. For those: set a monthly spend cap at the Anthropic console. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Fail loudly on sync-step errors (Copilot review) Drops the `|| true` after `git merge --ff-only`. Silently continuing on a failed sync reintroduces the exact skill_commits=0 + autofix-skips-files bugs this step prevents. A no-op fast-forward (local already at origin) still exits 0 cleanly, so the common case is unaffected. Only genuine divergence or merge errors now fail the step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually dispatched by @rdimitrov via workflow run https://github.com/stacklok/docs-website/actions/runs/24769641826.
This PR was created by the
Upstream Release Docsworkflow's bootstrap mode to document a release without waiting for Renovate. Content edits will be pushed as additional commits by the same workflow run.Content additions by upstream-release-docs
Source-verified against
stacklok/toolhiveat tagv0.23.1(wasv0.22.0). Two Claude Opus sessions produced this update: a generation pass running theupstream-release-docsskill over all six phases, then a fresh-context editorial pass runningdocs-reviewover the changed files. Prettier and ESLint auto-fixes were applied afterward.Note
The
upstream-release-docsskill ran to success butproduced no content commits on this PR. Likely causes:
was dispatched after an earlier PR for the same
tag had merged, or
mainis already ahead of thepinned base).
but the skill did not write
NO_CHANGES.md(whichwould have triggered the standard 'no changes'
note above).
existing prose already matches upstream behavior.
Only the version bump and any refreshed reference
assets are included in this PR.
Review guidance
Machine-generated reference files under
docs/toolhive/reference/cli/,static/api-specs/, anddocs/toolhive/reference/crds/are synced or regenerated from upstream release assets (separate commit, titled "Refresh reference assets") and should be spot-checked only. Commits authored by the skill contain hand-edited prose; review those for accuracy, not just style. If the "Gaps needing human context" section below is populated, each entry includes a Helper prompt for local Claude that a reviewer can paste verbatim into their local Claude Code session to resolve the gap. Fill those in before merging.Release contributors
Auto-assigned as reviewers (collaborators on this repo): @ChrisJBurns @jhrozek @rdimitrov @reyortiz3 @tgrunnagle