Skip to content

Commit e4b7dc1

Browse files
committed
Mark fields in the runconfig as deprecated
This applies to fields which either: - Do not appear to be used any more. - Are replaced by the telemetry middleware. We need to modify k8s to use the telemetry middleware object.
1 parent feee96c commit e4b7dc1

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

pkg/runner/config.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ type RunConfig struct {
8484
// EnvVars are the parsed environment variables as key-value pairs
8585
EnvVars map[string]string `json:"env_vars,omitempty" yaml:"env_vars,omitempty"`
8686

87+
// DEPRECATED: No longer appears to be used.
8788
// EnvFileDir is the directory path to load environment files from
8889
EnvFileDir string `json:"env_file_dir,omitempty" yaml:"env_file_dir,omitempty"`
8990

@@ -97,21 +98,27 @@ type RunConfig struct {
9798
// ContainerLabels are the labels to apply to the container
9899
ContainerLabels map[string]string `json:"container_labels,omitempty" yaml:"container_labels,omitempty"`
99100

101+
// DEPRECATED: Middleware configuration.
100102
// OIDCConfig contains OIDC configuration
101103
OIDCConfig *auth.TokenValidatorConfig `json:"oidc_config,omitempty" yaml:"oidc_config,omitempty"`
102104

105+
// DEPRECATED: Middleware configuration.
103106
// AuthzConfig contains the authorization configuration
104107
AuthzConfig *authz.Config `json:"authz_config,omitempty" yaml:"authz_config,omitempty"`
105108

109+
// DEPRECATED: Middleware configuration.
106110
// AuthzConfigPath is the path to the authorization configuration file
107111
AuthzConfigPath string `json:"authz_config_path,omitempty" yaml:"authz_config_path,omitempty"`
108112

113+
// DEPRECATED: Middleware configuration.
109114
// AuditConfig contains the audit logging configuration
110115
AuditConfig *audit.Config `json:"audit_config,omitempty" yaml:"audit_config,omitempty"`
111116

117+
// DEPRECATED: Middleware configuration.
112118
// AuditConfigPath is the path to the audit configuration file
113119
AuditConfigPath string `json:"audit_config_path,omitempty" yaml:"audit_config_path,omitempty"`
114120

121+
// DEPRECATED: Middleware configuration.
115122
// TelemetryConfig contains the OpenTelemetry configuration
116123
TelemetryConfig *telemetry.Config `json:"telemetry_config,omitempty" yaml:"telemetry_config,omitempty"`
117124

@@ -138,18 +145,22 @@ type RunConfig struct {
138145
// ProxyMode is the proxy mode for stdio transport ("sse" or "streamable-http")
139146
ProxyMode types.ProxyMode `json:"proxy_mode,omitempty" yaml:"proxy_mode,omitempty"`
140147

148+
// DEPRECATED: No longer appears to be used.
141149
// ThvCABundle is the path to the CA certificate bundle for ToolHive HTTP operations
142150
ThvCABundle string `json:"thv_ca_bundle,omitempty" yaml:"thv_ca_bundle,omitempty"`
143151

152+
// DEPRECATED: No longer appears to be used.
144153
// JWKSAuthTokenFile is the path to file containing auth token for JWKS/OIDC requests
145154
JWKSAuthTokenFile string `json:"jwks_auth_token_file,omitempty" yaml:"jwks_auth_token_file,omitempty"`
146155

147156
// Group is the name of the group this workload belongs to, if any
148157
Group string `json:"group,omitempty" yaml:"group,omitempty"`
149158

159+
// DEPRECATED: Middleware configuration.
150160
// ToolsFilter is the list of tools to filter
151161
ToolsFilter []string `json:"tools_filter,omitempty" yaml:"tools_filter,omitempty"`
152162

163+
// DEPRECATED: Middleware configuration.
153164
// ToolsOverride is a map from an actual tool to its overridden name and/or description
154165
ToolsOverride map[string]ToolOverride `json:"tools_override,omitempty" yaml:"tools_override,omitempty"`
155166

0 commit comments

Comments
 (0)