chore: go1.23 (#1776)

Author: RTann

.github/workflows/ci.yaml

@@ -39,7 +39,7 @@ jobs:
   pre-build-updater:
     runs-on: ubuntu-latest
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -72,7 +72,7 @@ jobs:
       fail-fast: false
       matrix: ${{ fromJson(needs.define-scanner-job-matrix.outputs.matrix).build_and_push }}
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -101,7 +101,7 @@ jobs:
   style-check:
     runs-on: ubuntu-latest
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -120,7 +120,7 @@ jobs:
   unit-tests:
     runs-on: ubuntu-latest
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -139,7 +139,7 @@ jobs:
   db-integration-tests:
     runs-on: ubuntu-latest
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -167,7 +167,7 @@ jobs:
     needs:
       - pre-build-updater
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -209,7 +209,7 @@ jobs:
     needs:
       - generate-genesis-dump
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -257,7 +257,7 @@ jobs:
       fail-fast: false
       matrix: ${{ fromJson(needs.define-scanner-job-matrix.outputs.matrix).build_and_push }}
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -314,7 +314,7 @@ jobs:
     needs:
       - generate-db-dump
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -365,7 +365,7 @@ jobs:
       fail-fast: false
       matrix: ${{ fromJson(needs.define-scanner-job-matrix.outputs.matrix).build_and_push }}
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -438,7 +438,7 @@ jobs:
       - build-images
     runs-on: ubuntu-latest
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     env:
       QUAY_RHACS_ENG_RW_USERNAME: ${{ secrets.QUAY_RHACS_ENG_RW_USERNAME }}
       QUAY_RHACS_ENG_RW_PASSWORD: ${{ secrets.QUAY_RHACS_ENG_RW_PASSWORD }}
@@ -484,7 +484,7 @@ jobs:
     needs:
       - generate-genesis-dump
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -602,7 +602,7 @@ jobs:
     needs:
       - generate-db-dump
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -630,7 +630,7 @@ jobs:
     needs:
       - generate-db-dump
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -664,7 +664,7 @@ jobs:
     needs:
       - generate-db-dump
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.github/workflows/sanity-check-vuln-updates.yaml

@@ -10,7 +10,7 @@ jobs:
       SLACK_WEBHOOK_ONCALL: ${{ secrets.SLACK_ONCALL_SCANNER_WEBHOOK }}
     runs-on: ubuntu-latest
     container:
-      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+      image: quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.golangci.yml

@@ -2,9 +2,14 @@
 
 run:
   timeout: 16m
+  modules-download-mode: readonly
+  go: "1.23"
 
 output:
-  format: "junit-xml:report.xml,colored-line-number"
+  formats:
+    - format: colored-line-number
+    - format: junit-xml
+      path: report.xml
 
 issues:
   exclude-use-default: false
@@ -31,13 +36,22 @@ issues:
     - linters:
         - revive
       text: "package-comments: should have a package comment"
+    - linters:
+        - gocritic
+      path: _test\.go
 
 linters-settings:
   gosec:
     includes:
       - G601 # Implicit memory aliasing of items from a range statement
   revive:
-    min-confidence: 0
+    rules:
+      - name: package-comments
+        disabled: true
+      - name: error-strings
+        disabled: true
+      - name: unexported-return
+        disabled: true
   govet:
     enable-all: true
     disable:
@@ -65,6 +79,8 @@ linters-settings:
     allow-unused: false # report any unused nolint directives
     require-explanation: false # don't require an explanation for nolint directives
     require-specific: true # require nolint directives to be specific about which linter is being skipped
+  staticcheck:
+    checks: [ all,-ST1000,-ST1001,-ST1003,-ST1005,-SA1019,-SA4001,-ST1016 ]
 
 linters:
   # please, do not use `enable-all`: it's deprecated and will be removed soon.
@@ -73,6 +89,7 @@ linters:
   enable:
     - asciicheck
     # - bodyclose
+    - copyloopvar
     # - deadcode
     # - depguard
     # - dogsled
@@ -84,7 +101,6 @@ linters:
     # - gochecknoinits
     # - gocognit
     # - goconst
-    - exportloopref
     - gocritic
     # - gocyclo
     # - godot

.openshift-ci/Dockerfile.build_root

@@ -10,4 +10,4 @@
 # - `make update` and commit the results
 # - run `/test pj-rehearse-max` on the openshift/release PR to validate the change
 
-FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5

.openshift-ci/build/Dockerfile.build-bundle

@@ -1,4 +1,4 @@
-FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
 
 COPY . /go/src/github.com/stackrox/scanner
 WORKDIR /go/src/github.com/stackrox/scanner

.openshift-ci/build/Dockerfile.build-db-bundle

@@ -1,4 +1,4 @@
-FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
 
 COPY . /go/src/github.com/stackrox/scanner
 WORKDIR /go/src/github.com/stackrox/scanner

.openshift-ci/build/Dockerfile.generate-db-dump

@@ -1,4 +1,4 @@
-FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
 
 COPY . /go/src/github.com/stackrox/scanner
 WORKDIR /go/src/github.com/stackrox/scanner

.openshift-ci/build/Dockerfile.generate-genesis-dump

@@ -1,4 +1,4 @@
-FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.3
+FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.4.5
 
 COPY . /go/src/github.com/stackrox/scanner
 WORKDIR /go/src/github.com/stackrox/scanner

BUILD_IMAGE_VERSION

@@ -1 +1 @@
-scanner-build-0.4.3
+scanner-build-0.4.5

api/v1/imagescan/convert.go

@@ -24,7 +24,7 @@ var (
 
 		m := make(map[apiV1.Note]v1.Note, numNotes)
 		for name, val := range v1.Note_value {
-			normalizedName := strings.ToLower(strings.Replace(name, "_", "", -1))
+			normalizedName := strings.ToLower(strings.ReplaceAll(name, "_", ""))
 			for note := apiV1.OSCVEsUnavailable; note < apiV1.SentinelNote; note++ {
 				if strings.HasPrefix(strings.ToLower(note.String()), normalizedName) {
 					m[note] = v1.Note(val)