Drop test_problematic_blocks_are_not_relayed_or_stored and expand test_static_problematic_tests

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jferrant

stacks-node/src/tests/neon_integrations.rs

@@ -8268,329 +8268,6 @@ fn test_problematic_blocks_are_not_mined() {
     follower_channel.stop_chains_coordinator();
 }
 
-// TODO: test in epoch 2.1 with parser_v2
-#[test]
-#[ignore]
-fn test_problematic_blocks_are_not_relayed_or_stored() {
-    if env::var("BITCOIND_TEST") != Ok("1".into()) {
-        return;
-    }
-
-    let bad_blocks_dir = "/tmp/bad-blocks-test_problematic_blocks_are_not_relayed_or_stored";
-    if fs::metadata(bad_blocks_dir).is_ok() {
-        fs::remove_dir_all(bad_blocks_dir).unwrap();
-    }
-    fs::create_dir_all(bad_blocks_dir).unwrap();
-
-    std::env::set_var("STACKS_BAD_BLOCKS_DIR", bad_blocks_dir);
-
-    let spender_sk_1 = StacksPrivateKey::from_hex(SK_1).unwrap();
-    let spender_sk_2 = StacksPrivateKey::from_hex(SK_2).unwrap();
-    let spender_sk_3 = StacksPrivateKey::from_hex(SK_3).unwrap();
-    let spender_stacks_addr_1 = to_addr(&spender_sk_1);
-    let spender_stacks_addr_2 = to_addr(&spender_sk_2);
-    let spender_stacks_addr_3 = to_addr(&spender_sk_3);
-    let spender_addr_1: PrincipalData = spender_stacks_addr_1.into();
-    let spender_addr_2: PrincipalData = spender_stacks_addr_2.into();
-    let spender_addr_3: PrincipalData = spender_stacks_addr_3.into();
-
-    let (mut conf, _) = neon_integration_test_conf();
-
-    conf.initial_balances.push(InitialBalance {
-        address: spender_addr_1,
-        amount: 1_000_000_000_000,
-    });
-    conf.initial_balances.push(InitialBalance {
-        address: spender_addr_2,
-        amount: 1_000_000_000_000,
-    });
-    conf.initial_balances.push(InitialBalance {
-        address: spender_addr_3,
-        amount: 1_000_000_000_000,
-    });
-
-    // force mainnet limits in 2.05 for this test
-    conf.burnchain.epochs = Some(EpochList::new(&[
-        StacksEpoch {
-            epoch_id: StacksEpochId::Epoch20,
-            start_height: 0,
-            end_height: 1,
-            block_limit: BLOCK_LIMIT_MAINNET_20.clone(),
-            network_epoch: PEER_VERSION_EPOCH_2_0,
-        },
-        StacksEpoch {
-            epoch_id: StacksEpochId::Epoch2_05,
-            start_height: 1,
-            end_height: 10_002,
-            block_limit: BLOCK_LIMIT_MAINNET_205.clone(),
-            network_epoch: PEER_VERSION_EPOCH_2_05,
-        },
-        StacksEpoch {
-            epoch_id: StacksEpochId::Epoch21,
-            start_height: 10_002,
-            end_height: 9223372036854775807,
-            block_limit: BLOCK_LIMIT_MAINNET_21.clone(),
-            network_epoch: PEER_VERSION_EPOCH_2_1,
-        },
-    ]));
-    conf.burnchain.pox_2_activation = Some(10_003);
-
-    test_observer::spawn();
-    test_observer::register_any(&mut conf);
-
-    let mut btcd_controller = BitcoinCoreController::from_stx_config(&conf);
-    btcd_controller
-        .start_bitcoind()
-        .expect("Failed starting bitcoind");
-
-    let mut btc_regtest_controller = BitcoinRegtestController::new(conf.clone(), None);
-    let http_origin = format!("http://{}", &conf.node.rpc_bind);
-
-    // something just over the limit of the expression depth
-    let exceeds_repeat_factor = 32;
-    let tx_exceeds_body_start = "{ a : ".repeat(exceeds_repeat_factor as usize);
-    let tx_exceeds_body_end = "} ".repeat(exceeds_repeat_factor as usize);
-    let tx_exceeds_body = format!("{tx_exceeds_body_start}u1 {tx_exceeds_body_end}");
-
-    let tx_exceeds = make_contract_publish(
-        &spender_sk_2,
-        0,
-        (tx_exceeds_body.len() * 100) as u64,
-        conf.burnchain.chain_id,
-        "test-exceeds",
-        &tx_exceeds_body,
-    );
-    let tx_exceeds_txid = StacksTransaction::consensus_deserialize(&mut &tx_exceeds[..])
-        .unwrap()
-        .txid();
-
-    let high_repeat_factor = 70;
-    let tx_high_body_start = "{ a : ".repeat(high_repeat_factor as usize);
-    let tx_high_body_end = "} ".repeat(high_repeat_factor as usize);
-    let tx_high_body = format!("{tx_high_body_start}u1 {tx_high_body_end}");
-
-    let tx_high = make_contract_publish(
-        &spender_sk_3,
-        0,
-        (tx_high_body.len() * 100) as u64,
-        conf.burnchain.chain_id,
-        "test-high",
-        &tx_high_body,
-    );
-    let tx_high_txid = StacksTransaction::consensus_deserialize(&mut &tx_high[..])
-        .unwrap()
-        .txid();
-
-    btc_regtest_controller.bootstrap_chain(201);
-
-    eprintln!("Chain bootstrapped...");
-
-    let mut run_loop = neon::RunLoop::new(conf.clone());
-    let blocks_processed = run_loop.get_blocks_processed_arc();
-    let channel = run_loop.get_coordinator_channel().unwrap();
-
-    thread::spawn(move || run_loop.start(None, 0));
-
-    // Give the run loop some time to start up!
-    wait_for_runloop(&blocks_processed);
-
-    // First block wakes up the run loop.
-    next_block_and_wait(&mut btc_regtest_controller, &blocks_processed);
-
-    // Second block will hold our VRF registration.
-    next_block_and_wait(&mut btc_regtest_controller, &blocks_processed);
-
-    // Third block will be the first mined Stacks block.
-    next_block_and_wait(&mut btc_regtest_controller, &blocks_processed);
-
-    debug!("Submit problematic tx_exceeds transaction {tx_exceeds_txid}");
-    std::env::set_var("STACKS_DISABLE_TX_PROBLEMATIC_CHECK", "1");
-    submit_tx(&http_origin, &tx_exceeds);
-    assert!(get_unconfirmed_tx(&http_origin, &tx_exceeds_txid).is_some());
-    std::env::set_var("STACKS_DISABLE_TX_PROBLEMATIC_CHECK", "0");
-
-    let (_, mut cur_files) = find_new_files(bad_blocks_dir, &HashSet::new());
-    let old_tip_info = get_chain_info(&conf);
-    let mut all_new_files = vec![];
-
-    for _i in 0..5 {
-        next_block_and_wait(&mut btc_regtest_controller, &blocks_processed);
-        let cur_files_old = cur_files.clone();
-        let (mut new_files, cur_files_new) = find_new_files(bad_blocks_dir, &cur_files_old);
-        all_new_files.append(&mut new_files);
-        cur_files = cur_files_new;
-    }
-
-    let tip_info = get_chain_info(&conf);
-
-    // blocks were all processed
-    assert_eq!(
-        tip_info.stacks_tip_height,
-        old_tip_info.stacks_tip_height + 5
-    );
-    // no blocks considered problematic
-    assert!(all_new_files.is_empty());
-
-    // one block contained tx_exceeds
-    let blocks = test_observer::get_blocks();
-    let mut found = false;
-    for block in blocks {
-        let transactions = block.get("transactions").unwrap().as_array().unwrap();
-        for tx in transactions.iter() {
-            let raw_tx = tx.get("raw_tx").unwrap().as_str().unwrap();
-            if raw_tx == "0x00" {
-                continue;
-            }
-            let tx_bytes = hex_bytes(&raw_tx[2..]).unwrap();
-            let parsed = StacksTransaction::consensus_deserialize(&mut &tx_bytes[..]).unwrap();
-            if let TransactionPayload::SmartContract(..) = &parsed.payload {
-                if parsed.txid() == tx_exceeds_txid {
-                    found = true;
-                    break;
-                }
-            }
-        }
-    }
-
-    assert!(found);
-
-    let tip = {
-        let sortdb = btc_regtest_controller.sortdb_mut();
-        let tip = SortitionDB::get_canonical_burn_chain_tip(sortdb.conn()).unwrap();
-        eprintln!("Sort db tip: {}", tip.block_height);
-        tip
-    };
-
-    btc_regtest_controller.build_next_block(1);
-
-    // wait for runloop to advance
-    wait_for(30, || {
-        let sortdb = btc_regtest_controller.sortdb_mut();
-        let new_tip = SortitionDB::get_canonical_burn_chain_tip(sortdb.conn()).unwrap();
-        Ok(new_tip.block_height > tip.block_height)
-    })
-    .expect("Runloop failed to advance");
-
-    // add another bad tx to the mempool.
-    // TODO: Forcibly mine a bad transaction to simulate a bad miner?
-    debug!("Submit problematic tx_high transaction {tx_high_txid}");
-    std::env::set_var("STACKS_DISABLE_TX_PROBLEMATIC_CHECK", "1");
-    submit_tx(&http_origin, &tx_high);
-    assert!(get_unconfirmed_tx(&http_origin, &tx_high_txid).is_some());
-    std::env::set_var("STACKS_DISABLE_TX_PROBLEMATIC_CHECK", "0");
-
-    let (_, mut cur_files) = find_new_files(bad_blocks_dir, &HashSet::new());
-    let old_tip_info = get_chain_info(&conf);
-    let mut all_new_files = vec![];
-
-    eprintln!("old_tip_info = {old_tip_info:?}");
-
-    // mine some blocks, and log problematic blocks
-    for _i in 0..6 {
-        next_block_and_wait(&mut btc_regtest_controller, &blocks_processed);
-        let cur_files_old = cur_files.clone();
-        let (mut new_files, cur_files_new) = find_new_files(bad_blocks_dir, &cur_files_old);
-        all_new_files.append(&mut new_files);
-        cur_files = cur_files_new;
-    }
-
-    let tip_info = get_chain_info(&conf);
-
-    // at least one block was mined (hard to say how many due to the raciness between the burnchain
-    // downloader and this thread).
-    info!(
-        "tip_info.stacks_tip_height = {}, old_tip_info.stacks_tip_height = {}",
-        tip_info.stacks_tip_height, old_tip_info.stacks_tip_height
-    );
-    assert!(tip_info.stacks_tip_height > old_tip_info.stacks_tip_height);
-    // one was problematic -- i.e. the one that included tx_high
-    assert_eq!(all_new_files.len(), 1);
-
-    // tx_high got mined by the miner
-    let blocks = test_observer::get_blocks();
-    let mut bad_block_height = None;
-    for block in blocks {
-        let transactions = block.get("transactions").unwrap().as_array().unwrap();
-        for tx in transactions.iter() {
-            let raw_tx = tx.get("raw_tx").unwrap().as_str().unwrap();
-            if raw_tx == "0x00" {
-                continue;
-            }
-            let tx_bytes = hex_bytes(&raw_tx[2..]).unwrap();
-            let parsed = StacksTransaction::consensus_deserialize(&mut &tx_bytes[..]).unwrap();
-            if let TransactionPayload::SmartContract(..) = &parsed.payload {
-                if parsed.txid() == tx_high_txid {
-                    bad_block_height = Some(block.get("block_height").unwrap().as_u64().unwrap());
-                }
-            }
-        }
-    }
-    assert!(bad_block_height.is_some());
-    let bad_block_height = bad_block_height.unwrap();
-
-    // follower should not process bad_block_height or higher
-    let new_tip_info = get_chain_info(&conf);
-
-    eprintln!("\nBooting follower\n");
-
-    // verify that a follower node that boots up with this node as a bootstrap peer will process
-    // all of the blocks available, even if they are problematic, with the checks on.
-    let (follower_conf, _, pox_sync_comms, follower_channel) = spawn_follower_node(&conf);
-
-    eprintln!(
-        "\nFollower booted on port {},{}\n",
-        follower_conf.node.p2p_bind, follower_conf.node.rpc_bind
-    );
-
-    wait_for(300, || {
-        let follower_tip_info = get_chain_info(&follower_conf);
-        eprintln!(
-            "\nFollower is at burn block {} stacks block {} (bad_block is {bad_block_height})\n",
-            follower_tip_info.burn_block_height, follower_tip_info.stacks_tip_height
-        );
-        Ok(
-            follower_tip_info.stacks_tip_height == new_tip_info.stacks_tip_height
-                || follower_tip_info.stacks_tip_height + 1 == bad_block_height,
-        )
-    })
-    .expect("Follower failed to advance");
-
-    // make sure we aren't just slow -- wait for the follower to do a few download passes
-    let num_download_passes = pox_sync_comms.get_download_passes();
-    eprintln!(
-        "\nFollower has performed {num_download_passes} download passes; wait for {}\n",
-        num_download_passes + 5
-    );
-
-    wait_for(30, || {
-        eprintln!(
-            "\nFollower has performed {} download passes; wait for {}\n",
-            pox_sync_comms.get_download_passes(),
-            num_download_passes + 5
-        );
-        Ok(pox_sync_comms.get_download_passes() >= num_download_passes + 5)
-    })
-    .expect("Follower failed to perform download passes");
-
-    eprintln!(
-        "\nFollower has performed {} download passes\n",
-        pox_sync_comms.get_download_passes()
-    );
-
-    let follower_tip_info = get_chain_info(&follower_conf);
-    eprintln!(
-        "\nFollower is at burn block {} stacks block {} (bad block is {bad_block_height})\n",
-        follower_tip_info.burn_block_height, follower_tip_info.stacks_tip_height
-    );
-
-    // follower rejects the bad block
-    assert_eq!(follower_tip_info.stacks_tip_height, bad_block_height - 1);
-
-    test_observer::clear();
-    channel.stop_chains_coordinator();
-    follower_channel.stop_chains_coordinator();
-}
-
 /// Verify that we push all boot receipts even before bootstrapping
 #[test]
 #[ignore]