Skip to content

Conversation

@Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Sep 11, 2025

Description

During the line-by-line diff analysis of the clarity-serialization crate, @fdefelici found out that CostOverflowingMath was not removed from the original clarity crate and ended up being duplicated.

This PR addressed that.

Given that this duplicated symbol slipped through the first two reviews, I did another review do check that ALL symbols in clarity-serialization have no duplicate declaration in clarity. Nothing else was found!

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc self-assigned this Sep 11, 2025
@Jiloc Jiloc requested review from a team as code owners September 11, 2025 14:08
@Jiloc Jiloc moved this to Status: In Review in Stacks Core Eng Sep 11, 2025
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Sep 11, 2025
@Jiloc Jiloc added this pull request to the merge queue Sep 11, 2025
Merged via the queue into stacks-network:develop with commit 863429f Sep 11, 2025
1 of 2 checks passed
@Jiloc Jiloc deleted the fix/remove-duplicate-CostOverflowingMath branch September 11, 2025 22:04
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.42%. Comparing base (f61ea59) to head (26afd25).
⚠️ Report is 60 commits behind head on develop.

❌ Your project status has failed because the head coverage (77.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6480      +/-   ##
===========================================
+ Coverage    71.17%   77.42%   +6.25%     
===========================================
  Files          557      558       +1     
  Lines       341798   342696     +898     
===========================================
+ Hits        243258   265332   +22074     
+ Misses       98540    77364   -21176     
Files with missing lines Coverage Δ
clarity/src/vm/costs/mod.rs 81.41% <ø> (+2.72%) ⬆️

... and 337 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61ea59...26afd25. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants