chore: wip

Author: chrisbbreuer

test/plugin-architecture.test.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import type { SetupContext, SetupPlugin } from '../src/setup'
 import { afterEach, beforeEach, describe, expect, it } from 'bun:test'
 import fs from 'node:fs'
@@ -150,51 +149,35 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
 
   describe('Plugin Discovery', () => {
     it('should discover no plugins when no integrations are configured', async () => {
-      const plugins = await pluginManager.discoverPlugins()
-
-      // In CI environments, there might be unexpected environment variables
-      // So instead of expecting specific counts, check that no built-in integration plugins exist
-      const integrationPlugins = plugins.filter(p =>
-        p.name === 'slack-integration'
-        || p.name === 'discord-integration'
-        || p.name === 'jira-integration',
-      )
-
-      // Debug info for CI troubleshooting
-      if (integrationPlugins.length > 0) {
-        console.log('🚨 Unexpected plugins found in clean environment:')
-        console.log(`Total plugins discovered: ${plugins.length}`)
-        console.log('All discovered plugins:')
-        plugins.forEach((p, i) => {
-          console.log(`  ${i + 1}. ${p.name}: enabled=${p.enabled}, version=${p.version}`)
-        })
-        console.log('Integration plugins (should be 0):')
-        integrationPlugins.forEach((p) => {
-          console.log(`  - ${p.name}: enabled=${p.enabled}`)
-        })
-        console.log('Environment check:')
-        console.log(`  - SLACK_WEBHOOK_URL: ${process.env.SLACK_WEBHOOK_URL ? 'SET' : 'UNSET'}`)
-        console.log(`  - DISCORD_WEBHOOK_URL: ${process.env.DISCORD_WEBHOOK_URL ? 'SET' : 'UNSET'}`)
-        console.log(`  - JIRA_API_TOKEN: ${process.env.JIRA_API_TOKEN ? 'SET' : 'UNSET'}`)
-        console.log(`  - JIRA_BASE_URL: ${process.env.JIRA_BASE_URL ? 'SET' : 'UNSET'}`)
-        console.log(`  - JIRA_PROJECT_KEY: ${process.env.JIRA_PROJECT_KEY ? 'SET' : 'UNSET'}`)
-        console.log('File system check:')
-        console.log(`  - .buddy exists: ${fs.existsSync('.buddy')}`)
-        console.log(`  - .buddy/slack-webhook exists: ${fs.existsSync('.buddy/slack-webhook')}`)
-        console.log(`  - .buddy/jira-config.json exists: ${fs.existsSync('.buddy/jira-config.json')}`)
-        console.log(`  - .buddy/discord-webhook exists: ${fs.existsSync('.buddy/discord-webhook')}`)
-        if (fs.existsSync('.buddy')) {
-          try {
-            const buddyFiles = fs.readdirSync('.buddy', { recursive: true })
-            console.log('  - .buddy contents:', buddyFiles)
-          }
-          catch {
-            console.log('  - .buddy contents: error reading')
-          }
-        }
+      // Mock the detection methods to ensure clean state in CI environment
+      const mockPluginManager = pluginManager as any
+      const originalHasSlack = mockPluginManager.hasSlackWebhook
+      const originalHasJira = mockPluginManager.hasJiraIntegration
+      const originalHasDiscord = mockPluginManager.hasDiscordWebhook
+
+      // Override detection methods to return false
+      mockPluginManager.hasSlackWebhook = async () => false
+      mockPluginManager.hasJiraIntegration = async () => false
+      mockPluginManager.hasDiscordWebhook = async () => false
+
+      try {
+        const plugins = await pluginManager.discoverPlugins()
+
+        // Filter out only integration plugins to test
+        const integrationPlugins = plugins.filter(p =>
+          p.name === 'slack-integration'
+          || p.name === 'discord-integration'
+          || p.name === 'jira-integration',
+        )
+
+        expect(integrationPlugins).toHaveLength(0)
+      }
+      finally {
+        // Restore original methods
+        mockPluginManager.hasSlackWebhook = originalHasSlack
+        mockPluginManager.hasJiraIntegration = originalHasJira
+        mockPluginManager.hasDiscordWebhook = originalHasDiscord
       }
-
-      expect(integrationPlugins).toHaveLength(0)
     })
 
     // Group file-based tests together with their own setup to ensure isolation
@@ -356,28 +339,39 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
     })
 
     it('should handle malformed custom plugin files gracefully', async () => {
-      fs.mkdirSync('.buddy/plugins', { recursive: true })
-      fs.writeFileSync(path.join('.buddy/plugins', 'invalid.json'), 'invalid json{')
-
-      // Should not throw, just log warning
-      const plugins = await pluginManager.discoverPlugins()
-
-      // Filter out any plugins that might exist in CI environment, only check for integration plugins
-      const integrationPlugins = plugins.filter(p =>
-        p.name === 'slack-integration'
-        || p.name === 'discord-integration'
-        || p.name === 'jira-integration',
-      )
-
-      // Debug info for CI troubleshooting
-      if (integrationPlugins.length > 0) {
-        console.log('🚨 Unexpected plugins found after malformed plugin test:')
-        integrationPlugins.forEach((p) => {
-          console.log(`  - ${p.name}: enabled=${p.enabled}`)
-        })
+      // Mock the detection methods to ensure clean state in CI environment
+      const mockPluginManager = pluginManager as any
+      const originalHasSlack = mockPluginManager.hasSlackWebhook
+      const originalHasJira = mockPluginManager.hasJiraIntegration
+      const originalHasDiscord = mockPluginManager.hasDiscordWebhook
+
+      // Override detection methods to return false
+      mockPluginManager.hasSlackWebhook = async () => false
+      mockPluginManager.hasJiraIntegration = async () => false
+      mockPluginManager.hasDiscordWebhook = async () => false
+
+      try {
+        fs.mkdirSync('.buddy/plugins', { recursive: true })
+        fs.writeFileSync(path.join('.buddy/plugins', 'invalid.json'), 'invalid json{')
+
+        // Should not throw, just log warning
+        const plugins = await pluginManager.discoverPlugins()
+
+        // Filter out only integration plugins to test
+        const integrationPlugins = plugins.filter(p =>
+          p.name === 'slack-integration'
+          || p.name === 'discord-integration'
+          || p.name === 'jira-integration',
+        )
+
+        expect(integrationPlugins).toHaveLength(0)
+      }
+      finally {
+        // Restore original methods
+        mockPluginManager.hasSlackWebhook = originalHasSlack
+        mockPluginManager.hasJiraIntegration = originalHasJira
+        mockPluginManager.hasDiscordWebhook = originalHasDiscord
       }
-
-      expect(integrationPlugins).toHaveLength(0)
     })
   })