New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need impl num_traits::ApproxEq for half data type #85

Open

Xudong-Huang opened this issue Apr 19, 2023 · 0 comments

Labels

Xudong-Huang commented Apr 19, 2023

so that we can compare by using the num_traits::assert_approx_eq macro

assert_approx_eq!(half::f16, self.test_atomic_add_result(input), out);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `ApproxEq` is not implemented for `f16`

The text was updated successfully, but these errors were encountered:

starkat99 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment