Speedup tests (#1421)

* use cargo-nextest instead of cargo test

* parallelize tests run in cairo-native-bin-utils

* Update .github/workflows/ci.yml

Co-authored-by: DiegoC <90105443+DiegoCivi@users.noreply.github.com>

* remove nextest config

* fix secp256_get_point_from_x and secp256_new implementation

* fix workflow

* allow specifying amount of jobs

* clippy

* Use --cargo-profile ci with nextest to preserve ci build profile

* Use cargo llvm-cov nextest for coverage while keeping run for binary

---------

Co-authored-by: DiegoC <90105443+DiegoCivi@users.noreply.github.com>
Co-authored-by: Gabriel Bosio <38794644+gabrielbosio@users.noreply.github.com>
Co-authored-by: gabrielbosio <gabrielbosio95@gmail.com>

Author: 3 people

.github/workflows/ci.yml

@@ -116,6 +116,10 @@ jobs:
       RUST_LOG: cairo_native=debug,cairo_native_test=debug
     steps:
       - uses: actions/checkout@v4
+      - name: Install testing tools
+        uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-nextest
       - name: check and free hdd space left
         run: |
           echo "Listing 20 largest packages"
@@ -167,6 +171,10 @@ jobs:
       RUST_LOG: cairo_native=debug,cairo_native_test=debug
     steps:
       - uses: actions/checkout@v4
+      - name: Install testing tools
+        uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-nextest
       - name: Rustup toolchain install
         uses: dtolnay/rust-toolchain@1.84.1
         with:

Cargo.lock

@@ -64,28 +64,28 @@ check: check-llvm
 
 .PHONY: test
 test: check-llvm
-	cargo test --profile ci --features=with-cheatcode,with-debug-utils,testing
+	cargo nextest run --cargo-profile ci --features=with-cheatcode,with-debug-utils,testing
 
 .PHONY: test-cairo
 test-cairo: check-llvm
 	bash ./scripts/test_cairo.sh
 
 .PHONY: proptest
 proptest: check-llvm
-	cargo test --profile ci --features=with-cheatcode,with-debug-utils,testing proptest
+	cargo nextest run --cargo-profile ci --features=with-cheatcode,with-debug-utils,testing proptest
 
 .PHONY: test-cli
 test-ci: check-llvm
-	cargo test --profile ci --features=with-cheatcode,with-debug-utils,testing
+	cargo nextest run --cargo-profile ci --features=with-cheatcode,with-debug-utils,testing
 
 .PHONY: proptest-cli
 proptest-ci: check-llvm
-	cargo test --profile ci --features=with-cheatcode,with-debug-utils,testing proptest
+	cargo nextest run --cargo-profile ci --features=with-cheatcode,with-debug-utils,testing proptest
 
 .PHONY: coverage
 coverage: check-llvm
-	cargo llvm-cov --verbose --profile ci --features=with-cheatcode,with-debug-utils,testing --workspace --lcov --output-path lcov.info
-	cargo llvm-cov --verbose --profile ci --features=with-cheatcode,with-debug-utils,testing --lcov --output-path lcov-test.info run --package cairo-native-test -- corelib
+	cargo llvm-cov nextest --verbose --profile ci --features=with-cheatcode,with-debug-utils,testing --workspace --lcov --output-path lcov.info
+	cargo llvm-cov run --verbose --profile ci --features=with-cheatcode,with-debug-utils,testing --lcov --output-path lcov-test.info --package cairo-native-test -- corelib
 
 .PHONY: doc
 doc: check-llvm

Makefile

@@ -22,3 +22,4 @@ num-traits.workspace = true
 scarb-metadata.workspace = true
 starknet-types-core.workspace = true
 tracing.workspace = true
+rayon.workspace = true

binaries/cairo-native-bin-utils/Cargo.toml

@@ -20,6 +20,7 @@ use cairo_native::{
 use colored::Colorize;
 use itertools::Itertools;
 use num_traits::ToPrimitive;
+use rayon::iter::{IntoParallelIterator, ParallelIterator};
 #[cfg(feature = "scarb")]
 use scarb_metadata::{PackageMetadata, TargetMetadata};
 use starknet_types_core::felt::Felt;
@@ -212,8 +213,9 @@ pub fn run_tests(
         failed_run_results: vec![],
         mismatch_reason: vec![],
     }));
+
     named_tests
-        .into_iter()
+        .into_par_iter()
         .map(
             |(name, test)| -> anyhow::Result<(String, Option<TestResult>)> {
                 if test.ignored {

binaries/cairo-native-bin-utils/src/test.rs

@@ -9,5 +9,6 @@ cairo-lang-test-plugin.workspace = true
 cairo-lang-test-runner.workspace = true
 cairo-native-bin-utils = { workspace = true, features = ["with-cheatcode"] }
 clap = { workspace = true, features = ["derive"] }
+rayon = { workspace = true }
 tracing-subscriber = { workspace = true, features = ["env-filter"]}
 tracing.workspace = true

binaries/cairo-native-test/Cargo.toml

@@ -41,6 +41,8 @@ struct Args {
     /// Compares test result with Cairo VM.
     #[arg(long, default_value_t = false)]
     compare_with_cairo_vm: bool,
+    #[arg(short = 'j', long)]
+    jobs: Option<u8>,
 }
 
 fn main() -> anyhow::Result<()> {
@@ -54,6 +56,12 @@ fn main() -> anyhow::Result<()> {
             .finish(),
     )?;
 
+    if let Some(num_jobs) = args.jobs {
+        rayon::ThreadPoolBuilder::new()
+            .num_threads(num_jobs as usize)
+            .build_global()?;
+    }
+
     check_compiler_path(args.single_file, &args.path)?;
 
     let compiler = TestCompiler::try_new(