`TransactionVersion` should be an `u8`

[tdelabro]

starknet-api/src/transaction.rs

Line 489 in a50e621

pub struct TransactionVersion(pub StarkFelt);

The transaction version is not part of the starknet state. It is occasionally used as an Felt to compute some hash, but most of the time it is manipulated by the sequencer in a non-provable context, so there is no reason for it to have Felt being its default representation.
It should be an u8, and a Felt can easily be constructed from an u8 when needed.

[raizo07]

Hello @tdelabro can this be assigned to me to work on?

[tdelabro]

Thanks for your enthusiasm @raizo07 sadly I have to give you the same answer as for this one: starkware-libs/blockifier#1703 (comment)

Let's wait for the repo maintainers to give an opinion