PHP 8.4: Deprecation warnings

[sstottelaar]

Hi,

When using the CLI with (Herd) PHP 8.4, I get deprecation warnings in my terminal:

`Deprecated: optional(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /Users/sjoerdstottelaar/.composer/vendor/illuminate/support/helpers.php on line 190

Deprecated: with(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /Users/sjoerdstottelaar/.composer/vendor/illuminate/support/helpers.php on line 430

Deprecated: Valet\writer(): Implicitly marking parameter $writer as nullable is deprecated, the explicit nullable type must be used instead in /Users/sjoerdstottelaar/.composer/vendor/laravel/valet/cli/includes/helpers.php on line 35

Deprecated: Valet\CommandLine::run(): Implicitly marking parameter $onError as nullable is deprecated, the explicit nullable type must be used instead in /Users/sjoerdstottelaar/.composer/vendor/laravel/valet/cli/Valet/CommandLine.php on line 36

Deprecated: Valet\CommandLine::runAsUser(): Implicitly marking parameter $onError as nullable is deprecated, the explicit nullable type must be used instead in /Users/sjoerdstottelaar/.composer/vendor/laravel/valet/cli/Valet/CommandLine.php on line 44

Deprecated: Valet\CommandLine::runCommand(): Implicitly marking parameter $onError as nullable is deprecated, the explicit nullable type must be used instead in /Users/sjoerdstottelaar/.composer/vendor/laravel/valet/cli/Valet/CommandLine.php on line 52`

I've just updated the CLI to 3.4.1, so I'm running the latest release. When switching back to PHP 8.3, the warnings are gone. The CLI is still functional, but not very usable:

[sstottelaar]

After reading up on Statamic and 8.4, I see that it isn't supported yet. I will close this issue and move forward on 8.3

[duncanmcclean]

Going to re-open this - the CLI should still support PHP 8.4.

The only reason we don't completely support PHP 8.4 in Core is because some of our dependencies still need updating.

[duncanmcclean]

What's the output of composer global show?

I'm not seeing any deprecation warnings using PHP 8.4 - wondering if your global dependencies are out-of-date.

[jesseleite]

I am seeing the deprecation warnings in php 8.4, but pretty sure they're all upstream issues of dependencies used by cms/core which still need to be updated for 8.4. Not sure there's anything to address in the cli package itself, but we can leave this issue open to revisit in the near future 👍

[duncanmcclean]

None of the errors in your screenshot are coming directly from the Statamic CLI. You can probably resolve them by updating your global composer dependencies using composer global update.

Once you install Statamic itself, you may continue seeing deprecation warnings from some of the packages Statamic depends on. For more information, see this comment on the PHP 8.4 pull request.

[bzerangue]

@duncanmcclean - This is still an issue. It is an issue with the Laravel Dependencies

laragraph/utils (and all the attached dependencies that depend on thecodingmachine/safe)

They need to update their dependency to thecodingmachine/safe to version 3.

I am having a mess of a problem to get it fixed until all these libraries update to v3. I guess I will have to remain on PHP 8.3.

[duncanmcclean]

Yes, we know. Hopefully it should be sorted soon, but its out of our hands. Please see the comment on the Core PR: statamic/cms#11114 (comment)