[6.x] Hash URLs when saving nocache regions in database #13152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when you store nocache regions in the database, visiting pages with long URLs can result in errors because of the max length of the column in the database.
You can workaround it by upping the column size, but that doesn't really "fix" the problem, just gets rid of it for now.
This pull request implements a suggestion (statamic/ideas#1329) where page URLs are MD5 hashed, resulting in a fixed length in the database.
I've also added an update script which publishes a migration converting URLs to MD5 hashes. Although, we could probably get away without this migration by telling folks to clear the static cache when deploying the v6 upgrade?
Fixes #11034
Closes statamic/ideas#1329