Skip to content

deep-review: collapse specialist findings in verdict output #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stbenjam merged 4 commits into from
Jul 23, 2026
Merged

deep-review: collapse specialist findings in verdict output #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3628cd
deep-review: collapse specialist findings in verdict output
not-stbenjam Jul 23, 2026
d80af2c
deep-review: split skill into main + references for progressive discl…
not-stbenjam Jul 23, 2026
82bcae7
deep-review: further trim SKILL.md to clear skillsaw warn threshold
not-stbenjam Jul 23, 2026
3bcb25e
Break specialist prompts into individual files
not-stbenjam Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 48 additions & 79 deletions .skillsaw-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,33 @@
{
"version": "1",
"generated_by": "skillsaw 0.14.0",
"generated_at": "2026-07-02T16:56:59.023230+00:00",
"generated_by": "skillsaw 0.11.4",
"generated_at": "2026-07-23T11:53:08.775821+00:00",
"violations": [
{
"fingerprint": "ad0d81a5c1374045",
"rule_id": "invalid-config",
"message": "Unknown rule 'hooks-dangerous' in config \u2014 rule does not exist and will be ignored",
"severity": "warning"
},
{
"fingerprint": "57903ba76e86bccb",
"rule_id": "invalid-config",
"message": "Unknown rule 'hooks-prohibited' in config \u2014 rule does not exist and will be ignored",
"severity": "warning"
},
{
"fingerprint": "e36410d037d531e5",
"rule_id": "invalid-config",
"message": "Unknown rule 'settings-dangerous' in config \u2014 rule does not exist and will be ignored",
"severity": "warning"
},
{
"fingerprint": "cb5b14e20999ffdf",
"rule_id": "plugin-readme",
"file_path": "plugins/reviews/README.md",
"message": "Missing README.md (recommended)",
"severity": "warning"
},
{
"fingerprint": "8a556ab9b3119812",
"rule_id": "context-budget",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"message": "Estimated 6,979 tokens exceeds skill error limit of 6,000",
"severity": "error",
"value": 6979,
"baseline_mode": "ceiling"
},
{
"fingerprint": "7371a0b665795d87",
"rule_id": "context-budget",
Expand All @@ -28,108 +37,68 @@
"value": 3055,
"baseline_mode": "ceiling"
},
{
"fingerprint": "5a7a0222e0cce3d5",
"rule_id": "content-weak-language",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 293,
"message": "Weak language (vagueness): 'properly' \u2014 Remove 'properly' \u2014 describe what correct behavior looks like",
"severity": "warning"
},
{
"fingerprint": "3723d0af0be379e6",
"rule_id": "content-weak-language",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 357,
"message": "Weak language (vagueness): 'correctly' \u2014 Remove 'correctly' \u2014 describe what correct behavior looks like",
"severity": "warning"
},
{
"fingerprint": "b282e7ef67afcefc",
"rule_id": "content-weak-language",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 363,
"message": "Weak language (vagueness): 'correctly' \u2014 Remove 'correctly' \u2014 describe what correct behavior looks like",
"severity": "warning"
},
{
"fingerprint": "da02977f1c071aa3",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 180,
"message": "'MUST' instruction at line 175 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"line": 167,
"message": "'MUST' instruction at line 162 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "bd78a190f2f9cf8f",
"fingerprint": "48ecbdfcae6dc811",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 186,
"message": "'MUST' instruction at line 181 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"file_path": "plugins/reviews/skills/deep-review/references/pr-posting.md",
"line": 45,
"message": "'CRITICAL' instruction at line 45 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"fingerprint": "4e0ccdf271e355e8",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 270,
"message": "'MUST' instruction at line 265 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"file_path": "plugins/reviews/skills/deep-review/references/specialist-prompts.md",
"line": 51,
"message": "'MUST' instruction at line 51 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"fingerprint": "4e0ccdf271e355e8",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 307,
"message": "'MUST' instruction at line 302 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"file_path": "plugins/reviews/skills/deep-review/references/specialist-prompts.md",
"line": 88,
"message": "'MUST' instruction at line 88 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"fingerprint": "4e0ccdf271e355e8",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 345,
"message": "'MUST' instruction at line 340 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"file_path": "plugins/reviews/skills/deep-review/references/specialist-prompts.md",
"line": 126,
"message": "'MUST' instruction at line 126 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"fingerprint": "4e0ccdf271e355e8",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 378,
"message": "'MUST' instruction at line 373 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"file_path": "plugins/reviews/skills/deep-review/references/specialist-prompts.md",
"line": 159,
"message": "'MUST' instruction at line 159 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"fingerprint": "4e0ccdf271e355e8",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 407,
"message": "'MUST' instruction at line 402 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 434,
"message": "'MUST' instruction at line 429 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fd21c95cef229fd3",
"rule_id": "content-critical-position",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 461,
"message": "'MUST' instruction at line 456 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"file_path": "plugins/reviews/skills/deep-review/references/specialist-prompts.md",
"line": 188,
"message": "'MUST' instruction at line 188 is in the attention dead zone (20-80%) \u2014 Move to the first 20% or last 20% of the file for better attention",
"severity": "warning"
},
{
"fingerprint": "fdf4ceeebfdca527",
"rule_id": "content-negative-only",
"file_path": "plugins/reviews/skills/deep-review/SKILL.md",
"line": 811,
"message": "Negative-only instruction without alternative: '- Never use in the initial review creation payload.'",
"line": 276,
"message": "Negative-only instruction without alternative: '- Never use `\"event\"` in the initial review creation payload.'",
"severity": "warning"
}
]
Expand Down
2 changes: 1 addition & 1 deletion plugins/reviews/.claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "reviews",
"description": "Multi-agent panel code review with specialist reviewers and runtime reproducers",
"version": "0.0.1",
"version": "0.0.3",
"author": {
"name": "stbenjam"
}
Expand Down
Loading
Loading