test: add tests

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/ndarray/vector/ctor/lib/main.js

@@ -165,7 +165,7 @@ function arraybuffer2vector( dtype, buffer, length, stride, byteOffset, order, o
 	N = length * stride;
 
 	// Adjust the byte offset to point to the element marking the beginning of the view:
-	if ( stride < 0 ) {
+	if ( stride < 0 ) { // TODO: the following is effectively unreachable code, as provided strides are never anything other than unity; however, we keep this around in the event that we want to extract this function to a separate package and would like to maintain generality
 		N *= -1;
 		o -= N * bytesPerElement( dtype );
 	}
@@ -483,6 +483,9 @@ function vector() {
 	if ( nargs === 2 ) {
 		// Case: vector( dtype, options )
 		if ( isDataType( arg0 ) ) {
+			if ( arg1 === null ) {
+				throw new TypeError( format( 'invalid argument. Options argument must be an object. Value: `%s`.', arg1 ) );
+			}
 			return vectorWithDType( 0, arg0, arg1 );
 		}
 		// Case: vector( arg0, dtype )
@@ -501,6 +504,9 @@ function vector() {
 			return arraybuffer2vector( DEFAULT_DTYPE, arg0, (arg0.byteLength-arg1)/bytesPerElement( DEFAULT_DTYPE ), 1, arg1, DEFAULT_ORDER );
 		}
 		// Case: vector( arg0, options )
+		if ( arg1 === null ) {
+			throw new TypeError( format( 'invalid argument. Options argument must be an object. Value: `%s`.', arg1 ) );
+		}
 		out = vectorWithDType( arg0, DEFAULT_DTYPE, arg1 );
 		if ( out === null ) {
 			throw new TypeError( format( 'invalid argument. First argument must be a length, ArrayBuffer, typed array, array-like object, or iterable. Value: `%s`.', arg0 ) );
@@ -523,6 +529,9 @@ function vector() {
 		}
 		// Case: vector( arg0, dtype, options )
 		if ( isDataType( arg1 ) ) {
+			if ( arg2 === null ) {
+				throw new TypeError( format( 'invalid argument. Options argument must be an object. Value: `%s`.', arg2 ) );
+			}
 			out = vectorWithDType( arg0, arg1, arg2 );
 			if ( out === null ) {
 				throw new TypeError( format( 'invalid argument. First argument must be a length, ArrayBuffer, typed array, array-like object, or iterable. Value: `%s`.', arg0 ) );
@@ -536,15 +545,15 @@ function vector() {
 		if ( !isNonNegativeInteger( arg1 ) ) {
 			throw new TypeError( format( 'invalid argument. Byte offset must be a nonnegative integer. Value: `%s`.', arg1 ) );
 		}
-		// Case: vector( ArrayBuffer, byteOffset, options )
-		if ( isPlainObject( arg2 ) ) {
-			return arraybuffer2vector( DEFAULT_DTYPE, arg0, (arg0.byteLength-arg1)/bytesPerElement( DEFAULT_DTYPE ), 1, arg1, resolveOrder( arg2 ), arg2 );
-		}
 		// Case: vector( ArrayBuffer, byteOffset, length )
-		if ( !isNonNegativeInteger( arg2 ) ) {
-			throw new TypeError( format( 'invalid argument. Length must be a nonnegative integer. Value: `%s`.', arg2 ) );
+		if ( isNonNegativeInteger( arg2 ) ) {
+			return arraybuffer2vector( DEFAULT_DTYPE, arg0, arg2, 1, arg1, DEFAULT_ORDER );
+		}
+		// Case: vector( ArrayBuffer, byteOffset, options )
+		if ( arg2 === null ) {
+			throw new TypeError( format( 'invalid argument. Options argument must be an object. Value: `%s`.', arg2 ) );
 		}
-		return arraybuffer2vector( DEFAULT_DTYPE, arg0, arg2, 1, arg1, DEFAULT_ORDER );
+		return arraybuffer2vector( DEFAULT_DTYPE, arg0, (arg0.byteLength-arg1)/bytesPerElement( DEFAULT_DTYPE ), 1, arg1, resolveOrder( arg2 ), arg2 );
 	}
 	arg3 = arguments[ 3 ];
 

lib/node_modules/@stdlib/ndarray/vector/ctor/test/test.js

@@ -37,5 +37,3 @@ tape( 'attached to the main export is a `factory` method', function test( t ) {
 	t.strictEqual( isMethod( vector, 'factory' ), true, 'returns expected value' );
 	t.end();
 });
-
-// FIXME: add tests (see array/typed and ndarray/zeros)