Skip to content

Commit 72477bd

Browse files
Fix openzeppelin and soroban-examples tests for v28 (#2761)
1 parent 2e6eb59 commit 72477bd

2 files changed

Lines changed: 2 additions & 24 deletions

File tree

‎.github/workflows/test-with-openzeppelin-contracts.yml‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ jobs:
5252
fail-fast: false
5353
matrix:
5454
dir: ${{ fromJSON(needs.collect-crates.outputs.dirs) }}
55-
experimental_spec_shaking_v2: [true, false]
5655
runs-on: ubuntu-latest
5756
steps:
5857
- uses: actions/checkout@v7
@@ -66,16 +65,6 @@ jobs:
6665
- run: echo "${{ github.workspace }}/stellar-cli" >> $GITHUB_PATH
6766
- run: rustup update
6867
- run: rustup target add wasm32v1-none
69-
- name: Enable experimental_spec_shaking_v2 feature
70-
if: matrix.experimental_spec_shaking_v2
71-
run: |
72-
find . -name Cargo.toml | while read -r file; do
73-
# Add feature to entries with existing features
74-
sed -i '/soroban-sdk = {/s|features = \[|features = ["experimental_spec_shaking_v2", |' "$file"
75-
# Add features field to entries without features
76-
sed -i '/soroban-sdk = {/{/features/!s| }|, features = ["experimental_spec_shaking_v2"] }|}' "$file"
77-
done
78-
cargo update -p soroban-sdk
7968
- name: Diff
8069
run: git diff
8170
- name: Build ${{ matrix.dir }}
@@ -88,7 +77,7 @@ jobs:
8877
echo "wasm=$wasm" | tee -a $GITHUB_OUTPUT
8978
- name: Set artifact name
9079
id: artifact-name
91-
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')${{ matrix.experimental_spec_shaking_v2 && '-spec-shaking-v2' || '' }}" | tee -a $GITHUB_OUTPUT
80+
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')" | tee -a $GITHUB_OUTPUT
9281
- name: Upload WASM artifacts
9382
uses: actions/upload-artifact@v7.0.1
9483
with:

‎.github/workflows/test-with-soroban-examples.yml‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ jobs:
5959
fail-fast: false
6060
matrix:
6161
dir: ${{ fromJSON(needs.collect-examples.outputs.dirs) }}
62-
experimental_spec_shaking_v2: [true, false]
6362
runs-on: ubuntu-latest
6463
steps:
6564
- uses: actions/checkout@v7
@@ -74,16 +73,6 @@ jobs:
7473
- run: echo "${{ github.workspace }}/stellar-cli" >> $GITHUB_PATH
7574
- run: rustup update
7675
- run: rustup target add wasm32v1-none
77-
- name: Enable experimental_spec_shaking_v2 feature
78-
if: matrix.experimental_spec_shaking_v2
79-
run: |
80-
find . -name Cargo.toml | while read -r file; do
81-
# Add feature to entries with existing features
82-
sed -i '/soroban-sdk = {/s|features = \[|features = ["experimental_spec_shaking_v2", |' "$file"
83-
# Add features field to entries without features
84-
sed -i '/soroban-sdk = {/{/features/!s| }|, features = ["experimental_spec_shaking_v2"] }|}' "$file"
85-
(cd "$(dirname "$file")" && cargo update -p soroban-sdk 2>/dev/null || true)
86-
done
8776
- name: Diff
8877
run: git diff
8978
- name: Build ${{ matrix.dir }}
@@ -96,7 +85,7 @@ jobs:
9685
echo "wasm=$wasm" | tee -a $GITHUB_OUTPUT
9786
- name: Set artifact name
9887
id: artifact-name
99-
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')${{ matrix.experimental_spec_shaking_v2 && '-spec-shaking-v2' || '' }}" | tee -a $GITHUB_OUTPUT
88+
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')" | tee -a $GITHUB_OUTPUT
10089
- name: Upload WASM artifacts
10190
uses: actions/upload-artifact@v7.0.1
10291
with:

0 commit comments

Comments
 (0)