Skip to content

Commit af88038

Browse files
chore(build): remove rollup build infrastructure (#5698)
this comprises: - the rollup bundle files - making the esbuild code now the default - renaming the modules in `scripts/bundles/plugins` which we want to keep around - removing the `build-rollup` CI as well as the configuration in other workflows for which build to use STENCIL-1018
1 parent 2863ca8 commit af88038

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+383
-2402
lines changed

.github/workflows/build-rollup.yml

-41
This file was deleted.

.github/workflows/main-rollup.yml

-53
This file was deleted.

.github/workflows/main.yml

-12
Original file line numberDiff line numberDiff line change
@@ -27,40 +27,28 @@ jobs:
2727
name: Analysis Tests
2828
needs: [build_core]
2929
uses: ./.github/workflows/test-analysis.yml
30-
with:
31-
build_name: stencil-core
3230

3331
docs_build_tests:
3432
name: Docs Build Tests
3533
needs: [build_core]
3634
uses: ./.github/workflows/test-docs-build.yml
37-
with:
38-
build_name: stencil-core
3935

4036
bundler_tests:
4137
name: Bundler Tests
4238
needs: [build_core]
4339
uses: ./.github/workflows/test-bundlers.yml
44-
with:
45-
build_name: stencil-core
4640

4741
component_starter_tests:
4842
name: Component Starter Smoke Test
4943
needs: [build_core]
5044
uses: ./.github/workflows/test-component-starter.yml
51-
with:
52-
build_name: stencil-core
5345

5446
e2e_tests:
5547
name: E2E Tests
5648
needs: [build_core]
5749
uses: ./.github/workflows/test-e2e.yml
58-
with:
59-
build_name: stencil-core
6050

6151
unit_tests:
6252
name: Unit Tests
6353
needs: [build_core]
6454
uses: ./.github/workflows/test-unit.yml
65-
with:
66-
build_name: stencil-core

.github/workflows/test-analysis.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
workflow_call:
55
# Make this a reusable workflow, no value needed
66
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
7-
inputs:
8-
build_name:
9-
description: Name for the build, used to resolve the correct build artifact
10-
required: true
11-
type: string
127

138
jobs:
149
analysis_test:
@@ -35,7 +30,7 @@ jobs:
3530
- name: Download Build Archive
3631
uses: ./.github/workflows/actions/download-archive
3732
with:
38-
name: ${{ inputs.build_name }}
33+
name: stencil-core
3934
path: .
4035
filename: stencil-core-build.zip
4136

.github/workflows/test-bundlers.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
workflow_call:
55
# Make this a reusable workflow, no value needed
66
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
7-
inputs:
8-
build_name:
9-
description: Name for the build, used to resolve the correct build artifact
10-
required: true
11-
type: string
127

138
jobs:
149
bundler_tests:
@@ -24,7 +19,7 @@ jobs:
2419
- name: Download Build Archive
2520
uses: ./.github/workflows/actions/download-archive
2621
with:
27-
name: ${{ inputs.build_name }}
22+
name: stencil-core
2823
path: .
2924
filename: stencil-core-build.zip
3025

.github/workflows/test-component-starter.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
workflow_call:
55
# Make this a reusable workflow, no value needed
66
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
7-
inputs:
8-
build_name:
9-
description: Name for the build, used to resolve the correct build artifact
10-
required: true
11-
type: string
127

138
jobs:
149
analysis_test:
@@ -44,7 +39,7 @@ jobs:
4439
- name: Download Build Archive
4540
uses: ./.github/workflows/actions/download-archive
4641
with:
47-
name: ${{ inputs.build_name }}
42+
name: stencil-core
4843
path: ./stencil-pack-destination
4944
filename: stencil-core-build.zip
5045

.github/workflows/test-docs-build.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
workflow_call:
55
# Make this a reusable workflow, no value needed
66
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
7-
inputs:
8-
build_name:
9-
description: Name for the build, used to resolve the correct build artifact
10-
required: true
11-
type: string
127

138
jobs:
149
docs_build_test:
@@ -35,7 +30,7 @@ jobs:
3530
- name: Download Build Archive
3631
uses: ./.github/workflows/actions/download-archive
3732
with:
38-
name: ${{ inputs.build_name }}
33+
name: stencil-core
3934
path: .
4035
filename: stencil-core-build.zip
4136

.github/workflows/test-e2e.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
workflow_call:
55
# Make this a reusable workflow, no value needed
66
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
7-
inputs:
8-
build_name:
9-
description: Name for the build, used to resolve the correct build artifact
10-
required: true
11-
type: string
127

138
jobs:
149
e2e_test:
@@ -35,7 +30,7 @@ jobs:
3530
- name: Download Build Archive
3631
uses: ./.github/workflows/actions/download-archive
3732
with:
38-
name: ${{ inputs.build_name }}
33+
name: stencil-core
3934
path: .
4035
filename: stencil-core-build.zip
4136

.github/workflows/test-unit.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@ on:
44
workflow_call:
55
# Make this a reusable workflow, no value needed
66
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
7-
inputs:
8-
build_name:
9-
description: Name for the build, used to resolve the correct build artifact
10-
required: true
11-
type: string
127

138
jobs:
149
unit_test:
@@ -35,7 +30,7 @@ jobs:
3530
- name: Download Build Archive
3631
uses: ./.github/workflows/actions/download-archive
3732
with:
38-
name: ${{ inputs.build_name }}
33+
name: stencil-core
3934
path: .
4035
filename: stencil-core-build.zip
4136

jest.config.js

-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ module.exports = {
2020
collectCoverageFrom: [
2121
'<rootDir>/scripts/**/*.{js,jsx,ts,tsx}',
2222
'!<rootDir>/scripts/build/**/*.{js,jsx,ts,tsx}',
23-
'!<rootDir>/scripts/bundles/helpers/compiler-cjs-intro.js',
24-
'!<rootDir>/scripts/bundles/helpers/compiler-cjs-outro.js',
2523
'<rootDir>/src/app-data/**/*.{js,jsx,ts,tsx}',
2624
'<rootDir>/src/app-globals/**/*.{js,jsx,ts,tsx}',
2725
'<rootDir>/src/cli/**/*.{js,jsx,ts,tsx}',

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
"testing/"
2424
],
2525
"scripts": {
26-
"build.rollup": "npm run tsc.scripts && npm run tsc.prod && npm run rollup.prod.ci",
2726
"build": "npm run clean && npm run tsc.scripts && npm run tsc.prod && node scripts/build --prod --ci",
2827
"build.watch": "npm run build -- --watch",
2928
"build.updateSelectorEngine": "node scripts/build/updateSelectorEngine.js",

0 commit comments

Comments
 (0)