Skip to content

Review notes on the open PR queue (27 Aug) #503

Description

@Optic00

Notes from reviewing most of the open PRs over the last day; the detail sits on each PR. Collected here so the state of the queue is in one place. The grouping below is one way to rank it, not a decision — and two of the small ones are mine, which is worth weighing.

Green and small

PR Size What it is
#488 +304 Transcript shows Speaker N instead of collapsing every remote speaker into one lane (#486). 13/13 green.
#497 +4053 The i18n gate: a lint ratchet plus a checked-in English copy inventory. 13/13 green, mostly generated files.

This has to be decided

i18n direction — #494 vs #497. Both land on the same ground. #497 is only the gate (no strings move); #494 is the framework plus a zh-TW locale. They compose in that order, but #494 currently reworks English copy on the way rather than moving it — the Obsidian setting loses its "one-way, edits are never overwritten" guarantee, the mic-device explanation shrinks to five words, and progress labels like Clearing…/Saving… both become "Loading…". Details are on #494. I've closed my own #441 — it was stale and in the way — so this is a two-way choice.

#495 (Apple SystemLanguageModel as the default summariser). 13/13 green and well built. But _adopt_apple_system_default() moves existing macOS installs to apple:system on the next config load, and the Apple path summarises long meetings through a 2800-character snapshot instead of gemma-12b map-reduce. Same meeting, reprocessed, gives a thinner note with nothing saying why. That is a product decision rather than a review question.

Blocked on their authors

One thing that isn't a PR

e2e-nightly.yml has been red for at least seven consecutive nights, always the same job (T2 real-summarize), everything else green. Ollama answers /api/chat with a 500 and the job never logs the response body. Worth fixing before the next release, since a permanently red canary reports nothing. I can take that one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions