Static and Dynamic Testing Tasks

Author: stephdavis1

Screenshots/Issue 01. IF statement wrong..png

@@ -0,0 +1,26 @@
+## PDA Software Development
+#### Implementation and Testing Unit Level 8
+
+##### Testing tasks
+
+#### Task 1: Static Testing
+
+  Carry out static testing on testing_task_1.md in the part_1_docs folder .  
+
+  Read through the code. Comment any errors you can see but do not correct them in this file.
+
+  (Remember you can use `#` to comment in Ruby code.)
+
+
+#### Task 2: Dynamic Testing
+
+  Carry out dynamic testing on card_game.py in the part_2_code folder.
+
+  Read through the code. Complete the test file and write a test for each function. Screenshot the test code and the tests failing Correct the errors you spotted in task A and screenshot the tests passing. Save screenshots in the same folder as the code.
+
+### Submitting
+
+
+ - If you haven't already, create a GitHub repo for this task. Once you have completed submit the GitHub link via Canvas.
+
+  You can also use screenshots of the tests, tests failing and the tests passing, you can use this evidence for week 5.

Screenshots/Issue 01. IF statement. FIXED.png

@@ -0,0 +1,45 @@
+### Testing task 1:
+
+# Carry out static testing on the code below.
+# Comment on any errors that you see below.
+
+Note that we are only looking for errors here.
+
+**Not** any issues with, i.e.: 
+Thinking that methods should be renamed or should be class level, or using string interpolation etc. 
+
+These aren't errors but rather standards that vary from developer to developer. 
+
+Only comment on errors that would stop the tests running.
+
+```python
+
+class CardGame:
+
+  # Class doesn't start with an def __init__(self): method.
+  def check_for_ace(self, card):
+    if card.value = 1: # possibly wrong should be card.value == 1:
+      return True
+    else # colon is missing 
+      return False
+   
+
+ 
+ 
+  
+  dif highest_card(self, card1 card2):  # Spelling error in the word 'dif' should be 'def'.
+  if card1.value > card2.value: # There is an indent error.
+    return card # typo needs to be card1.
+  else:
+    return card2
+  
+
+
+# Indent is off here as well.
+def cards_total(self, cards):
+  total # total does not have anything associated with it. Should be an = 0.
+  for card in cards:
+    total += card.value
+    return "You have a total of" + total # return statement needs to be indented back.
+  
+```

Screenshots/Issue 02. else statement FIXED.png

@@ -0,0 +1 @@
+__pycache__

Screenshots/Issue 02. else statement wrong.png

@@ -0,0 +1,5 @@
+import unittest
+from specs.card_game_tests import TestCardGame
+
+if __name__ == "__main__":
+    unittest.main()

Screenshots/Issue 03. dif instead of def. FIXED.png

@@ -0,0 +1,25 @@
+import unittest
+from src.card import Card
+from src.card_game import CardGame
+
+class TestCardGame(unittest.TestCase):
+    def setUp(self):
+        self.ace = Card('hearts', 1)
+        self.card2 = Card('hearts', 5)
+        self.card3 = Card('hearts', 6)
+        self.deck_of_cards = [self.ace, self.card2, self.card3]
+        self.card_game = CardGame()
+
+    def test_check_for_ace(self):
+        self.assertTrue(self.card_game.check_for_ace(self.ace))
+        self.assertFalse(self.card_game.check_for_ace(self.card2))
+
+    def test_highest_card(self):
+        self.hightest_card = self.card_game.highest_card(self.card2, self.card3)
+        self.assertEqual(self.hightest_card.value, 6)
+
+        self.hightest_card = self.card_game.highest_card(self.card3, self.card2)
+        self.assertEqual(self.hightest_card.value, 6)
+
+    def test_cards_total(self):
+        self.assertEqual(self.card_game.cards_total(self.deck_of_cards),"You have a total of 12")

Screenshots/Issue 03. dif instead of def..png

@@ -0,0 +1,6 @@
+
+class Card:
+
+  def __init__(self, suit, value):
+    self.suit = suit
+    self.value = value

Screenshots/Issue 04. Missing coma in def. FIXED.png

@@ -0,0 +1,29 @@
+### Testing task 2 code:
+
+# Carry out dynamic testing on the code below.
+
+# Correct the errors below that you spotted in task 1.
+
+class CardGame:
+
+
+  def check_for_ace(self, card):
+    if card.value == 1:
+      return True
+    else:
+      return False
+   
+
+  def highest_card(self, card1, card2):
+    if card1.value > card2.value:
+      return card1
+    else:
+      return card2
+  
+
+
+  def cards_total(self, cards):
+    total = 0
+    for card in cards:
+      total += card.value
+    return "You have a total of " + str(total)