Skip to content

Warning: defvaralias overwriting efrit-model value #23

@junghan0611

Description

@junghan0611

Issue

When loading efrit, a warning appears:

Warning (defvaralias): Overwriting value of 'efrit-model' by aliasing to 'efrit-default-model'

Cause

The variable efrit-model is defined in two places with conflicting definitions:

  1. efrit-do.el:111 - defines efrit-model as defcustom:
(defcustom efrit-model "claude-sonnet-4-20250514"
  1. efrit-chat.el:58 - defines efrit-model as alias to efrit-default-model:
(defvaralias 'efrit-model 'efrit-default-model)
  1. efrit-config.el:123 - defines the target variable:
(defcustom efrit-default-model "claude-3-5-sonnet-20241022"

Load Order Issue

When efrit-do.el loads before efrit-chat.el:

  1. efrit-model gets set to "claude-sonnet-4-20250514"
  2. Then efrit-chat.el tries to alias it to efrit-default-model
  3. This overwrites the existing value, triggering the warning

Suggested Fix

Consolidate efrit-model definition to a single location (likely efrit-config.el) and use defvar declarations in other files:

;; In efrit-do.el and efrit-chat.el, replace defcustom/defvaralias with:
(defvar efrit-model)  ; defined in efrit-config

Or remove the alias in efrit-chat.el and use efrit-default-model directly where needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions