Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectral-action reports success due to "Error: You have exceeded a secondary rate limit." #660

Open
bdoughan-snow opened this issue Jan 9, 2024 · 3 comments

Comments

@bdoughan-snow
Copy link

The spectal-action is not failing when linting an OpenAPI document with a large (over 1000 errors). The issue appears to be that it is hitting "Error: You have exceeded a secondary rate limit".

Context

PRs with OpenAPI documents with a large amount of errors are passing the check. This makes the check useless in this case.

Current Behavior

PRs with OpenAPI documents with a large amount of errors are passing the check.

Expected Behavior

OpenAPI docs that should fail the PR check are passing.

Possible Workaround/Solution

I have not found a workaround yet. If the spectral-action hits this error it should report a failuire.

Steps to Reproduce

  1. Use spectral-action to lint a document with over 1000 errors.

Environment

  • Version used: 0.8.11
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop or mobile):
  • Link to your environment/workspace/project:
@maxwlang
Copy link

maxwlang commented Feb 7, 2024

Seeing this too

@owebb98
Copy link

owebb98 commented Jun 10, 2024

Also seeing this

@acolombier
Copy link

I have made a fix for it here - it should allow you to publish 1000+ (I tried with my project containing 1400, which all got published successfully)

diff --git a/.github/workflows/spectral.yml b/.github/workflows/spectral.yml
index e1b254ab72..4aca040f10 100644
--- a/.github/workflows/spectral.yml
+++ b/.github/workflows/spectral.yml
@@ -16,6 +16,6 @@ jobs:
       - uses: actions/checkout@v3
 
       # Run Spectral
-      - uses: stoplightio/[email protected]
+      - uses: acolombier/spectral-action@de2a9d36832b9a5c674d583e1538396ecc94adf4
         with:
           file_glob: 'doc/api/*.yaml'

Happy to create a PR for it, but sadly, I'm not sure if any maintainer is looking at that repo....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants