From 9c074932b60ca694d95bd2fde9ab4e37f7a5cf6b Mon Sep 17 00:00:00 2001 From: Henry Okonkwo Date: Fri, 15 Dec 2023 21:04:46 +0100 Subject: [PATCH 01/10] chore: update ds --- src/components/TextField/textfield.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/TextField/textfield.scss b/src/components/TextField/textfield.scss index 6bc76c07..1bb18392 100644 --- a/src/components/TextField/textfield.scss +++ b/src/components/TextField/textfield.scss @@ -1,5 +1,6 @@ .sb-textfield { width: 100%; + padding-bottom: 10px; &--error { &.sb-textfield--inline-label .sb-textfield__inner { From 3f6be281cf3073f5f53072b4a2ff13a08fb72795 Mon Sep 17 00:00:00 2001 From: Henry Okonkwo Date: Mon, 18 Dec 2023 14:37:58 +0100 Subject: [PATCH 02/10] chore: update ds --- src/components/TextField/textfield.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/TextField/textfield.scss b/src/components/TextField/textfield.scss index 1bb18392..6bc76c07 100644 --- a/src/components/TextField/textfield.scss +++ b/src/components/TextField/textfield.scss @@ -1,6 +1,5 @@ .sb-textfield { width: 100%; - padding-bottom: 10px; &--error { &.sb-textfield--inline-label .sb-textfield__inner { From b5404e74e420dbf33bada70239990ad257beaf88 Mon Sep 17 00:00:00 2001 From: Marcos Ramos Date: Fri, 29 Dec 2023 12:04:00 -0300 Subject: [PATCH 03/10] task(shape-14): sbTextField - adding the capability to pass the icon right description --- src/components/TextField/SbTextField.vue | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/components/TextField/SbTextField.vue b/src/components/TextField/SbTextField.vue index 8e272578..d54f9da7 100644 --- a/src/components/TextField/SbTextField.vue +++ b/src/components/TextField/SbTextField.vue @@ -90,6 +90,7 @@ Date: Fri, 29 Dec 2023 12:35:27 -0300 Subject: [PATCH 04/10] task(shape-14): increasing node-version from tests.yml --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 385a4872..53392695 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 cache: 'yarn' - run: yarn - run: yarn test:unit From 82d32fdf3fe9393b37010f51c2e30c091b227571 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emanuel=20Gon=C3=A7alves?= Date: Thu, 4 Jan 2024 18:47:45 -0300 Subject: [PATCH 05/10] feat(shape-55): add default slot to the SbHeaderTitle component --- .../EditorHeader/__tests__/HeaderTitle.spec.js | 17 +++++++++++++++++ .../EditorHeader/components/HeaderTitle.vue | 1 + 2 files changed, 18 insertions(+) diff --git a/src/components/EditorHeader/__tests__/HeaderTitle.spec.js b/src/components/EditorHeader/__tests__/HeaderTitle.spec.js index c16d406f..281fcf78 100644 --- a/src/components/EditorHeader/__tests__/HeaderTitle.spec.js +++ b/src/components/EditorHeader/__tests__/HeaderTitle.spec.js @@ -22,4 +22,21 @@ describe('Test if Header title renderer correctly', () => { expect(wrapper.findComponent(SbButton).exists()).toBe(true) }) + + it('Test to check if the default slot renders correctly', () => { + const defaultSlotText = 'Just a text' + const wrapper = mount(SbHeaderTitle, { + props: { + headerTitle: 'Awesome cms', + headerSubtitle: 'Its true', + }, + slots: { + default: ` ${defaultSlotText} `, + }, + }) + + expect(wrapper.find('[data-testid="default-slot-text"]').text()).toBe( + defaultSlotText, + ) + }) }) diff --git a/src/components/EditorHeader/components/HeaderTitle.vue b/src/components/EditorHeader/components/HeaderTitle.vue index b34ed070..1f51b332 100644 --- a/src/components/EditorHeader/components/HeaderTitle.vue +++ b/src/components/EditorHeader/components/HeaderTitle.vue @@ -10,6 +10,7 @@

{{ headerTitle }}

{{ headerSubtitle }}

+ From 49bb1120b6cbdaff6bf5aab37837cfaf8d95a489 Mon Sep 17 00:00:00 2001 From: Carolina Faria Date: Fri, 5 Jan 2024 12:08:10 +0000 Subject: [PATCH 06/10] style(on-1601): add min-height to sidebar icons --- src/components/Sidebar/sidebar.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/Sidebar/sidebar.scss b/src/components/Sidebar/sidebar.scss index 6dccf60f..170b565b 100644 --- a/src/components/Sidebar/sidebar.scss +++ b/src/components/Sidebar/sidebar.scss @@ -126,6 +126,7 @@ list-style: none; svg { + min-height: $s-5; min-width: $s-5; } From 22295b2f1d03a9560e802ba787f1a31ae56e2d91 Mon Sep 17 00:00:00 2001 From: Marcos Ramos Date: Fri, 5 Jan 2024 09:11:58 -0300 Subject: [PATCH 07/10] fix(shape-6): fix sidebar-ideas internal icon --- src/lib/internal-icons.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lib/internal-icons.js b/src/lib/internal-icons.js index c31dd044..9167cc62 100644 --- a/src/lib/internal-icons.js +++ b/src/lib/internal-icons.js @@ -791,7 +791,12 @@ const sidebarIcons = { 'sidebar-ideas': { viewBox: '0 0 24 24', path: ` - + + + + + + `, }, 'sidebar-quickstart': { From 0cb28b2a8600f39889516125eef32a5855397bd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emanuel=20Gon=C3=A7alves?= Date: Wed, 10 Jan 2024 16:33:16 -0300 Subject: [PATCH 08/10] refactor: remove the reference to showAvatar data in the SelectInner component in the tests here, it seems this variable is not necessary since we have the isAvatarVisible also, there was an watcher that set the isAvatarVisible value to the showAvatar --- .../Select/components/SelectInner.vue | 27 ++----------------- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/src/components/Select/components/SelectInner.vue b/src/components/Select/components/SelectInner.vue index bc1862f1..507976e7 100644 --- a/src/components/Select/components/SelectInner.vue +++ b/src/components/Select/components/SelectInner.vue @@ -73,7 +73,7 @@ /> -
+
({ - showAvatar: false, - }), - computed: { dataTestid() { return this.$attrs['data-testid'] || 'sb-select-inner' @@ -318,8 +314,7 @@ export default { this.hasValue && !this.multiple && !this.searchInputText.length && - !this.isAvatarVisible && - !this.showAvatar + !this.isAvatarVisible ) }, @@ -430,16 +425,6 @@ export default { }, watch: { - searchInputText(val) { - if ( - this.avatarData && - val === this.avatarData?.label && - this.isAvatarVisible - ) { - this.showAvatar = true - } - }, - modelValue(val, oldVal) { const isSameValue = JSON.stringify(val) === JSON.stringify(oldVal) if (this.isSearchTextVisible && !isSameValue) { @@ -448,14 +433,6 @@ export default { } return } - - if (this.isAvatarVisible) { - this.showAvatar = true - } - }, - - isAvatarVisible(val) { - this.showAvatar = val }, }, From 4002af1f00e4166808e30d826f842cf9292e2297 Mon Sep 17 00:00:00 2001 From: Henry Okonkwo Date: Fri, 12 Jan 2024 14:42:37 +0200 Subject: [PATCH 09/10] chore: update ds --- src/components/FormItem/form-item.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/FormItem/form-item.scss b/src/components/FormItem/form-item.scss index e92a9011..aa553677 100644 --- a/src/components/FormItem/form-item.scss +++ b/src/components/FormItem/form-item.scss @@ -55,3 +55,7 @@ .sb-form-item__required { color: $red; } + +.sb-form-item__body{ + padding-bottom: $s-2; +} From 8a424dcab1e7d78aaf845ea73cde26d425a39164 Mon Sep 17 00:00:00 2001 From: Marcos Ramos Date: Sun, 14 Jan 2024 22:56:54 -0300 Subject: [PATCH 10/10] fix(shape-9): fix tags count tooltip in the SbSelect --- src/components/Select/components/SelectInner.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Select/components/SelectInner.vue b/src/components/Select/components/SelectInner.vue index 507976e7..508d4937 100644 --- a/src/components/Select/components/SelectInner.vue +++ b/src/components/Select/components/SelectInner.vue @@ -416,7 +416,7 @@ export default { tagsCountTooltip() { return { label: this.tagLabels - ?.map((item) => item.label) + ?.map((item) => item[this.itemLabel]) .slice(1) .join(', '), position: 'top',