Skip to content

Commit 8613e45

Browse files
committed
Fix checkstyle
1 parent a41b7d4 commit 8613e45

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/ci-release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ permissions:
1313
contents: read
1414

1515
jobs:
16+
# Docker doesn't work with macOS arm64 at this moment.
17+
# Therefore, we can't run native image tracing agent during tests on this type of CI runner.
18+
# Instead, we generate reachability-metadata in as a separte job, then copy it to next jobs.
1619
reachability-metadata:
1720
runs-on: ubuntu-24.04
1821
name: generate-reachability-metadata

src/test/java/com/streamx/cli/test/annotation/DisabledIfDockerUnavailable.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
package com.streamx.cli.test.annotation;
22

3-
import org.junit.jupiter.api.extension.ExtendWith;
4-
53
import java.lang.annotation.ElementType;
64
import java.lang.annotation.Retention;
75
import java.lang.annotation.RetentionPolicy;
86
import java.lang.annotation.Target;
7+
import org.junit.jupiter.api.extension.ExtendWith;
98

9+
/** Docker doesn't work with macOS arm64 at this moment.
10+
Therefore, we can't run tests which rely on docker engine on this type of CI runner.
11+
At the same time, it would be nice to keep other tests working.
12+
*/
1013
@Target({ElementType.TYPE, ElementType.METHOD})
1114
@Retention(RetentionPolicy.RUNTIME)
1215
@ExtendWith(DockerAvailableCondition.class)

src/test/java/com/streamx/cli/test/annotation/DockerAvailableCondition.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
package com.streamx.cli.test.annotation;
22

3+
import java.util.concurrent.TimeUnit;
34
import org.junit.jupiter.api.extension.ConditionEvaluationResult;
45
import org.junit.jupiter.api.extension.ExecutionCondition;
56
import org.junit.jupiter.api.extension.ExtensionContext;
67

7-
import java.util.concurrent.TimeUnit;
8-
98
public class DockerAvailableCondition implements ExecutionCondition {
109

1110
@Override
@@ -19,6 +18,7 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
1918
return ConditionEvaluationResult.enabled("Docker is available");
2019
}
2120
} catch (Exception ignored) {
21+
// ignore
2222
}
2323
return ConditionEvaluationResult.disabled("Docker is not available");
2424
}

0 commit comments

Comments
 (0)