Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incorrect result types #547

Open
inlet opened this issue Nov 22, 2024 · 4 comments
Open

[BUG]: Incorrect result types #547

inlet opened this issue Nov 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@inlet
Copy link

inlet commented Nov 22, 2024

What happened?

const result = await checkout.applyPromotionCode(code);

here result is:

export type StripeCheckoutApplyPromotionCodeResult =
  | {type: 'success'; success: StripeCheckoutSession}
  | {type: 'error'; error: ApplyPromotionCodeError};

However result.type doesn't exist, instead it returns only the { error: { message: string } }, therefore it cannot infer the type.

Same applies to:

await checkout.confirm()

Environment

No response

Reproduction

No response

@inlet inlet added the bug Something isn't working label Nov 22, 2024
@inlet inlet changed the title [BUG]: Types for errors in Result [BUG]: Incorrect result types Nov 22, 2024
Copy link

stale bot commented Dec 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 28, 2024
@inlet
Copy link
Author

inlet commented Dec 28, 2024

Any updates?

@stale stale bot removed the stale label Dec 28, 2024
Copy link

stale bot commented Jan 18, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 18, 2025
@inlet
Copy link
Author

inlet commented Jan 18, 2025

Any updates?

@stale stale bot removed the stale label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant