-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe TypeScript types affecting tsc build performance? #845
Comments
Hi @lensbart , Thanks for sharing this. I'll look into whether we can do anything on our side about I believe you might be able to investigate this by commenting out your usages of stripe, and seeing if your build (incremental and initial) are slower or faster? The |
I am also having issues with my TS build getting much slower on upgrade to v8 |
Having this issue too. Ideally we'd be able to just import what we need, for example Unfortunately we rely on packages that include stripe so we don't have direct control over this. |
We're also seeing very long compile times after adding the Commenting out the |
Some more info: it looks like we are using I just purged the I would suggest anyone experiencing issues try deleting your |
Posted as a question on Stack Overflow before
Since our TypeScript build was taking longer than expected for initial builds, I included
incremental: true
intsconfig.json
so that atsconfig.tsbuildinfo
would be created which would drastically shorten the initial build time oftsc --watch
.Upon inspection, the file contains 19999+ occurrences of the word
stripe
, in the form of:Where
./app/enums/licensetype.ts
(the key) is a file in our codebase and the string values in the array are presumably the types that are loaded in memory for this file?I’m quite surprised by this, because we use the Stripe NPM module in just a couple of files, and none of our other ~90 dependencies occur in this list.
tsconfig.tsbuildinfo
is 388k lines, which seems a bit on the high side, especially because most of these lines are the Stripe types listed above.How can I optimise my TypeScript configuration such that Stripe doesn’t slow down our build?
Many thanks in advance.
The text was updated successfully, but these errors were encountered: