Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums should be exported as values #60

Open
ViliamKopecky opened this issue Nov 15, 2022 · 0 comments
Open

Enums should be exported as values #60

ViliamKopecky opened this issue Nov 15, 2022 · 0 comments

Comments

@ViliamKopecky
Copy link

Summary

Enums should be exported as values - not only as types.

// this works, but is bad
import { type PaymentStatus } from '@stripe/terminal-js/pure'
const bad = terminal.getPaymentStatus() === ('waiting_for_input' as PaymentStatus)
// this throws error, but should work
import { PaymentStatus } from '@stripe/terminal-js/pure'
const good = terminal.getPaymentStatus() === PaymentStatus.WAITING_FOR_INPUT)

// TypeError: Cannot read properties of undefined (reading 'WAITING_FOR_INPUT')

Other information

Small repo that should work, but throws error:

https://codesandbox.io/s/competent-cloud-xku665?file=/src/index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant