Extract persistence fs mocks into a module

Author: strugee

test/lib/persistence.js

@@ -0,0 +1,60 @@
+/*
+
+  Copyright 2017 AJ Jordan <[email protected]>.
+
+  This file is part of lazymention.
+
+  lazymention is free software: you can redistribute it and/or modify it
+  under the terms of the GNU Affero General Public License as published
+  by the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  lazymention is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  Affero General Public License for more details.
+
+  You should have received a copy of the GNU Affero General Public
+  License along with lazymention. If not, see
+  <https://www.gnu.org/licenses/>.
+
+*/
+
+'use strict';
+
+// TODO test this file
+
+var assert = require('perjury').assert,
+    _ = require('lodash'),
+    mockFs = require('mock-fs');
+
+function buildMockSetup(configurePath) {
+	return {
+		topic: function(passthrough) {
+			if (configurePath) require('../../lib/persistence').configure('/tmp');
+
+			mockFs({
+				'/tmp': mockFs.directory()
+			});
+			return passthrough;
+		},
+		teardown: function(app) {
+			mockFs.restore();
+			return true;
+		},
+		'it works': function(err, app) {
+			assert.ifError(err);
+		}
+	};
+};
+
+function wrapFsMocks(configurePath, obj) {
+	if (!obj) {
+		obj = configurePath;
+		configurePath = true;
+	}
+
+	return _.assign({}, buildMockSetup(configurePath), obj);
+}
+
+module.exports.wrapFsMocks = wrapFsMocks;

test/persistence-test.js

@@ -25,7 +25,8 @@ License along with lazymention. If not, see
 var vows = require('perjury'),
     assert = vows.assert,
     _ = require('lodash'),
-    mockFs = require('mock-fs');
+    persistenceutil = require('./lib/persistence'),
+    wrapFsMocks = persistenceutil.wrapFsMocks;
 
 vows.describe('persistence module').addBatch({
 	'When we require the module': {
@@ -40,20 +41,7 @@ vows.describe('persistence module').addBatch({
 			assert.isFunction(db.get);
 			assert.isFunction(db.set);
 		},
-		'and we mock out the `fs` module': {
-			topic: function(db) {
-				mockFs({
-					'/tmp': mockFs.directory()
-				});
-				return db;
-			},
-			teardown: function() {
-				mockFs.restore();
-				return true;
-			},
-			'it works': function(err) {
-				assert.ifError(err);
-			},
+		'and we mock out the `fs` module': wrapFsMocks(false, {
 			'and we configure the module with a path': {
 				topic: function(db) {
 					db.configure('/tmp');
@@ -118,6 +106,6 @@ vows.describe('persistence module').addBatch({
 					}
 				}
 			}
-		}
+		})
 	}
 }).export(module);

test/webmention-test.js

@@ -27,6 +27,8 @@ var vows = require('perjury'),
     mockFs = require('mock-fs'),
     proxyquire = require('proxyquire'),
     sinon = require('sinon'),
+    persistenceutil = require('./lib/persistence'),
+    wrapFsMocks = persistenceutil.wrapFsMocks,
     data = {
 	    singleLink: '<a href="http://nicenice.website/blag/new-puppy">So cute!</a>',
 	    multipleLinks: '<a href="http://magic.geek/pics/another-doggo">Even cuter!</a> I love <a href="http://catscatscats.org/">cats</a> too!'
@@ -58,21 +60,7 @@ vows.describe('Webmention module').addBatch({
 		'it exports a function': function(err, webmention) {
 			assert.isFunction(webmention[1]);
 		},
-		'and we set up persistence mocks': {
-			topic: function(webmention) {
-				require('../lib/persistence').configure('/tmp');
-				mockFs({
-					'/tmp': mockFs.directory()
-				});
-				return webmention;
-			},
-			teardown: function() {
-				mockFs.restore();
-				return true;
-			},
-			'it works': function(err) {
-				assert.ifError(err);
-			},
+		'and we set up persistence mocks': wrapFsMocks({
 			'and we call the module with a post': {
 				topic: function(fns) {
 					var webmention = fns[1],
@@ -86,6 +74,7 @@ vows.describe('Webmention module').addBatch({
 					           });
 				},
 				'it works': function(err) {
+					console.log(err);
 					assert.ifError(err);
 				},
 				'the spy was called': function(err, fns) {
@@ -167,6 +156,6 @@ vows.describe('Webmention module').addBatch({
 					}
 				}
 			}
-		}
+		})
 	}
 }).export(module);