Skip to content

Fix Support fo venv #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seanlaw opened this issue Jul 18, 2024 · 0 comments
Closed

Fix Support fo venv #1008

seanlaw opened this issue Jul 18, 2024 · 0 comments

Comments

@seanlaw
Copy link
Contributor

seanlaw commented Jul 18, 2024

There have been several reported issues:

#730 (comment)
#957 (comment)

where test.sh seems to exhibit strange behavior where it appears to be executing black in the home/root directory! However, what's really happening is that developers are setting up a virtual environment INSIDE of the stumpy directory:

cd stumpy.git
python -m venv .venv  # Creates a `.venv` directory that houses its own isolated Python environment
source .venv/bin/activate
./setup.sh ci  # Or `./setup.sh dev` would work as well
./test.sh

Then, black looks inside of the .venv directory and discovers a tonne of files that do not conform to black standards and that are not technically included in stumpy. flake8 also experiences a similar issue! Thus, we need to remedy this by having both black and flake8 ignore the presence of a .venv directory by adding a --extend-exclude=".venv" flag to the test.sh file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant