Made namespace prefix handling for some common xml attributes such as xml, xmlns, xsi, xlink

Author: Rodion-Bozhenko

dom.go

@@ -10,6 +10,17 @@ import (
 	"strings"
 )
 
+const (
+	xmlPrefix   = "xml"
+	xmlUrl      = "http://www.w3.org/XML/1998/namespace"
+	xmlnsPrefix = "xmlns"
+	xmlnsUrl    = "http://www.w3.org/2000/xmlns"
+	xlinkPrefix = "xlink"
+	xlinkUrl    = "http://www.w3.org/1999/xlink"
+	xsiPrefix   = "xsi"
+	xsiUrl      = "http://www.w3.org/2001/XMLSchema-instance"
+)
+
 func Must(doc *Document, err error) *Document {
 	if err != nil {
 		panic(err)
@@ -49,9 +60,23 @@ func Parse(r io.Reader) (*Document, error) {
 			el.Parent = e
 			el.Name = token.Name.Local
 			for _, attr := range token.Attr {
-				name := attr.Name.Local
+				var name, ns string
 				if attr.Name.Space != "" {
-					name = fmt.Sprintf("%s:%s", attr.Name.Space, attr.Name.Local)
+					ns = attr.Name.Space
+					switch ns {
+					case xmlnsUrl:
+						name = fmt.Sprintf("%s:%s", xmlnsPrefix, attr.Name.Local)
+					case xmlUrl:
+						name = fmt.Sprintf("%s:%s", xmlPrefix, attr.Name.Local)
+					case xlinkUrl:
+						name = fmt.Sprintf("%s:%s", xlinkPrefix, attr.Name.Local)
+					case xsiUrl:
+						name = fmt.Sprintf("%s:%s", xsiPrefix, attr.Name.Local)
+					default:
+						name = fmt.Sprintf("%s:%s", attr.Name.Space, attr.Name.Local)
+					}
+				} else {
+					name = attr.Name.Local
 				}
 				el.Attributes = append(el.Attributes, &Attribute{
 					Name:  name,

dom_test.go

@@ -0,0 +1,86 @@
+package xmldom
+
+import (
+	"strings"
+	"testing"
+)
+
+func TestParseNamespaces(t *testing.T) {
+	testCases := []struct {
+		inputXML     string
+		expectedAttr map[string]string
+	}{
+		{
+			inputXML: `<root xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="https://github.com/subchen/go-xmldom"></root>`,
+			expectedAttr: map[string]string{
+				"xmlns:xlink": "http://www.w3.org/1999/xlink",
+				"xlink:href":  "https://github.com/subchen/go-xmldom",
+			},
+		},
+		{
+			inputXML: `<root xml:lang="en" xsi:type="string" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"></root>`,
+			expectedAttr: map[string]string{
+				"xml:lang":  "en",
+				"xsi:type":  "string",
+				"xmlns:xsi": "http://www.w3.org/2001/XMLSchema-instance",
+			},
+		},
+	}
+
+	for _, testCase := range testCases {
+		r := strings.NewReader(testCase.inputXML)
+		doc, err := Parse(r)
+		if err != nil {
+			t.Fatalf("Unexpected error: %v", err)
+		}
+
+		root := doc.Root
+		attributes := root.Attributes
+
+		attrMap := make(map[string]string)
+		for _, attr := range attributes {
+			attrMap[attr.Name] = attr.Value
+		}
+
+		for expectedName, expectedValue := range testCase.expectedAttr {
+			if value, exists := attrMap[expectedName]; !exists {
+				t.Errorf("Attribute %s was expected but not found", expectedName)
+			} else if value != expectedValue {
+				t.Errorf("Attribute %s has unexpected value. Got: %s, Want: %s", expectedName, value, expectedValue)
+			}
+		}
+	}
+}
+
+func TestSvgParse(t *testing.T) {
+	root := Must(ParseFile("test.svg")).Root
+
+	imagesNodes := root.FindByName("image")
+	if len(imagesNodes) < 4 {
+		t.Fatalf("No images")
+	}
+}
+
+func TestSvgAttrNamespace(t *testing.T) {
+	root := Must(ParseFile("test.svg")).Root
+	uses := root.FindByName("use")
+
+	var contains bool
+	for _, a := range root.Attributes {
+		if a.Name == "xmlns:xlink" {
+			contains = true
+		}
+	}
+
+	if !contains {
+		t.Fatalf("Expect root to contain xmlns:xlink attribute")
+	}
+
+	for _, u := range uses {
+		for _, a := range u.Attributes {
+			if a.Name != "xlink:href" {
+				t.Fatalf("Expect use tag to contain xlink:href attribute but got %s", a.Name)
+			}
+		}
+	}
+}

example_test.go

@@ -2,7 +2,6 @@ package xmldom_test
 
 import (
 	"fmt"
-	"testing"
 
 	"github.com/subchen/go-xmldom"
 )
@@ -155,12 +154,3 @@ func ExampleNewDocument() {
 	//   </testsuite>
 	// </testsuites>
 }
-
-func TestAttrNamespace(t *testing.T) {
-	root := xmldom.Must(xmldom.ParseXML(ExampleXml)).Root
-	node := root.FindByID("AttrNamespace")
-
-	if node.Attributes[0].Name != "xmlns:test" {
-		t.Fatalf("Expected attribute name to be xmlns:test, got=%s", node.Attributes[0].Name)
-	}
-}