-
Notifications
You must be signed in to change notification settings - Fork 291
When no websockets and multi-editors switch user rights to read-only #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
So to recap the need associated with this issue. When a user opens a document he has been invited on he cannot edit the document and save new versions to the server even if he has been invited as an editor. @sampaccoud are you ok with what's described above ? If yes @rl-83 can you provide us with a design ? |
Linked with #456 |
Here is my updated proposal. -> Waiting for the definitive text to update the prototype |
This is the text for the modal: "La configuration réseau de votre poste de travail ou de votre accès internet de ne permet pas d'utiliser l'édition collaborative. |
@sampaccoud is this ok for you ? if yes we'll start the dev |
Small grammatical corrections: EN FR Update: I specified that it was the shared documents that were not editable. |
To summarize, user will switch to "Reader" mode if :
|
The following sentence is wrong: "Pour accéder à l'édition collaborative, veuillez contacter votre service informatique afin d'autoriser les WebSockets." My suggestion: "Pour accéder à l'édition collaborative, veuillez demander à votre service informatique de vous autoriser les WebSockets vers ${HOSTNAME_SERVER}." |
Could we add the condition that at least one other user is currently connected? This would minimize occurrences of locking the document for users with no websocket. |
Yes we can know the connected users on the server, but we have a case where multiple users not connected on the server are editing at the same time to tackle as well so. It will require a mechanism to add and remove their presence manually to the collab server (http endpoint). |
"a mechanism to add and remove their presence manually to the collab server (http endpoint)": this seems a wise locking solution, for users short of websockets. |
Feature Request
Is your feature request related to a problem or unsupported use case? Please describe.
Here is the related issue : #456
Describe the solution you'd like
When a user has websockets blocked AND there are multiple possible editors (the document is shared with other people or there an edit link that allow collaboration) they should be able to only read the document and an alert banner should display to explain why.
Describe alternatives you've considered
This is until we implement some kind of alternative solution like polling. (#437)
Discovery, Documentation, Adoption, Migration Strategy

(full mockup in the "In progress" area.
The text was updated successfully, but these errors were encountered: