Skip to content

Replace "Edition" by "Editing" #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mellkior
Copy link

@mellkior mellkior commented Apr 8, 2025

Changed

Frontend

  • 🌐 The link sharing visibility options were "Reading" and "Edition". Edition is not the correct word to use in this situation, I changed it to "Editing" for parallelism with "Reading". Another reasonable and arguably more natural option (for English) would be to change "Reading" to "Viewer" and "Edition" to "Editor", however, "Reading" and "Editing" are correct.
    Screenshot from 2025-04-07 21-57-44

Documentation

  • ✏️ The --signoff option was misspelled as --sign-off in CONTRIBUTING.md, I fixed it.
  • 📝 The https://gitmoji.dev/ link in CONTRIBUTING.md was not using standard markdown link syntax, I updated it.

Documentation changes removed from the PR as requested.

Update "Edition" to "Editing" in document sharing interface.

Signed-off-by: mellkior <[email protected]>
@virgile-dev
Copy link
Collaborator

Hey @mellkior Thanks for your contribution.
I already adressed your two fixes on contributing.md in this PR : #871
Could you keep only your first commit ?
I do agree that Editing is clearer.
Thanks in advance.

@mellkior
Copy link
Author

mellkior commented Apr 16, 2025

@virgile-dev Done.

@virgile-dev virgile-dev changed the title Language and Documentation Improvements Replace "Edition" by "Editing" Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants