Skip to content

Commit 42df87c

Browse files
Merge branch 'docs/third-iteration-on-writing-end-to-end-tests-doc' into 'master'
Third iteration on writing end to end tests doc Closes #62158 See merge request gitlab-org/gitlab-ce!28716
2 parents 15c05f5 + 6d77a2f commit 42df87c

File tree

2 files changed

+262
-162
lines changed

2 files changed

+262
-162
lines changed

qa/docs/best_practices.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ The majority of the end-to-end tests require some state to be built in the appli
44

55
A good example is a user being logged in as a pre-condition for testing the feature.
66

7-
But if the login feature is already covered with end-to-end tests through the GUI, there is no reason to perform such an expensive task to test the functionality of creating a project, or importing a repo, even if this features depend on a user being logged in. Let's see an example to make things clear.
7+
But if the login feature is already covered with end-to-end tests through the GUI, there is no reason to perform such an expensive task to test the functionality of creating a project, or importing a repo, even if these features depend on a user being logged in. Let's see an example to make things clear.
88

99
Let's say that, on average, the process to perform a successful login through the GUI takes 2 seconds.
1010

@@ -33,6 +33,6 @@ Finally, interacting with the application only by its GUI generates a higher rat
3333
**The takeaways here are:**
3434

3535
- Building state through the GUI is time consuming and it's not sustainable as the test suite grows.
36-
- When depending only on the GUI to create the application's state and tests fail due to front-end issues, we can't rely on the test failures rate, and we generates a higher rate of test flakiness.
36+
- When depending only on the GUI to create the application's state and tests fail due to front-end issues, we can't rely on the test failures rate, and we generate a higher rate of test flakiness.
3737

38-
Now that we are aware of all of it, [let's go create some tests](writing_tests_from_scratch.md).
38+
Now that we are aware of all of it, [let's go create some tests](writing_tests_from_scratch.md#this-document-covers-the-following-items).

0 commit comments

Comments
 (0)