fix: when resolving dep versions, it should respect versions in deno.lock (#625)

* fix: when resolving dep versions, it should respect versions in deno.lock

* chore: add an integration test

Author: nyannyacha

crates/base/test_cases/pin-package/.gitignore

@@ -0,0 +1 @@
+!deno.lock

crates/base/test_cases/pin-package/deno.json

@@ -0,0 +1,3 @@
+{
+  "workspace": []
+}

crates/base/test_cases/pin-package/deno.lock

@@ -0,0 +1,6 @@
+import isOdd from "npm:is-odd@^3";
+import json from "npm:is-odd@^3/package.json" with { type: "json" };
+
+console.log(isOdd);
+
+Deno.serve(() => new Response(json["version"]));

crates/base/test_cases/pin-package/index.ts

@@ -4224,6 +4224,27 @@ async fn test_user_worker_with_import_map() {
   }
 }
 
+#[tokio::test]
+#[serial]
+async fn test_pin_package_version_correctly() {
+  integration_test!(
+    "./test_cases/pin-package",
+    NON_SECURE_PORT,
+    "",
+    None,
+    None,
+    None,
+    (|resp| async {
+      let res = resp.unwrap();
+      assert!(res.status().as_u16() == 200);
+
+      let body_bytes = res.bytes().await.unwrap();
+      assert_eq!(body_bytes, r#"3.0.0"#);
+    }),
+    TerminationToken::new()
+  );
+}
+
 #[derive(Deserialize)]
 struct ErrorResponsePayload {
   msg: String,

crates/base/tests/integration_tests.rs

@@ -356,7 +356,15 @@ impl EmitterFactory {
           } else {
             CliNpmResolverCreateOptions::Managed(
               CliManagedNpmResolverCreateOptions {
-                snapshot: CliNpmResolverManagedSnapshotOption::Specified(None),
+                snapshot: if let Some(lockfile) =
+                  options.maybe_lockfile().cloned()
+                {
+                  CliNpmResolverManagedSnapshotOption::ResolveFromLockfile(
+                    lockfile,
+                  )
+                } else {
+                  CliNpmResolverManagedSnapshotOption::Specified(None)
+                },
                 maybe_lockfile: options.maybe_lockfile().cloned(),
                 fs,
                 http_client_provider: self.http_client_provider().clone(),

crates/deno_facade/emitter.rs

@@ -179,7 +179,7 @@ async fn resolve_snapshot(
         let guard = lockfile.lock();
         (guard.overwrite, guard.filename.clone())
       };
-      if overwrite {
+      if !overwrite {
         let snapshot = snapshot_from_lockfile(
           lockfile.clone(),
           &registry_info_provider.as_npm_registry_api(),