Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a precommit hook to validate commit messages #64

Open
inian opened this issue Aug 12, 2021 · 3 comments · May be fixed by #78
Open

add a precommit hook to validate commit messages #64

inian opened this issue Aug 12, 2021 · 3 comments · May be fixed by #78
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@inian
Copy link
Member

inian commented Aug 12, 2021

it's annoying that commits dont get picked up by our semantic-commit-analyser plugin and they are not reflected properly in our changelog. our version number is also not bumped and we need to do fake commits like this.

We should have a pre commit hook (via husky?) to validate commit messages adhere to the right format
@inian inian added the bug Something isn't working label Aug 12, 2021
@kiwicopple kiwicopple added the good first issue Good for newcomers label Aug 18, 2021
@97amarnathk
Copy link

I can pick this up.

@97amarnathk 97amarnathk linked a pull request Oct 7, 2021 that will close this issue
Open
@97amarnathk
Copy link

@kiwicopple #78 fixes this issue.

@darora
Copy link
Contributor

darora commented Feb 7, 2022

I'd much rather have a CI check for this rather than husky running on every commit. It's also the standard approach we're using across the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: setup husky for commit lint 97amarnathk/storage-api
4 participants
@darora @inian @kiwicopple @97amarnathk