Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload page if appointment is not confirmed #69

Closed
wants to merge 2 commits into from

Conversation

azimb
Copy link

@azimb azimb commented May 31, 2021

resolves #53

As suggested by @sushrut111 here: #53 (comment)

If the vaccination center becomes full while confirming a booking, reloading the page to re-trigger the flow.

if (enableautoconfirm) $("ion-button.confirm-btn")[0].click();
if (enableautoconfirm)
try{
$("ion-button.confirm-btn")[0].click();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would click event throw an exception? How did you test this?

Copy link
Author

@azimb azimb May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that if the confirmation doesn't succeed, the click would throw an exception. Maybe a bad assumption, sorry

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to be sorry. That's okay. Try to figure out how you can detect a failure.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't test because I'm unable to reproduce the error easily, as I'd only get to that page if there are any slots available in the first place. I looked at other button click examples and came up with this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will look into ways of detecting confirmation failure

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need available slots, check Gadchiroli district of Maharashtra state - you would get plenty there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no slots available for 18+ unfortunately

Copy link
Author

@azimb azimb May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a button click that's not successful, for example Minimum age limit is 45 years for this center, does not throw an exception.

@azimb azimb marked this pull request as draft June 1, 2021 18:24
@sushrut111
Copy link
Owner

Implemented in v4.2.0

@sushrut111 sushrut111 closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to go back to search page if appointment is not booked.
2 participants