-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload page if appointment is not confirmed #69
Conversation
if (enableautoconfirm) $("ion-button.confirm-btn")[0].click(); | ||
if (enableautoconfirm) | ||
try{ | ||
$("ion-button.confirm-btn")[0].click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would click event throw an exception? How did you test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that if the confirmation doesn't succeed, the click would throw an exception. Maybe a bad assumption, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to be sorry. That's okay. Try to figure out how you can detect a failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't test because I'm unable to reproduce the error easily, as I'd only get to that page if there are any slots available in the first place. I looked at other button click examples and came up with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will look into ways of detecting confirmation failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need available slots, check Gadchiroli district of Maharashtra state - you would get plenty there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no slots available for 18+ unfortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a button click that's not successful, for example Minimum age limit is 45 years for this center
, does not throw an exception.
Implemented in v4.2.0 |
resolves #53
As suggested by @sushrut111 here: #53 (comment)
If the vaccination center becomes full while confirming a booking, reloading the page to re-trigger the flow.