Option to disable "Please wait" tab

[kankaristo]

Thanks for an awesome package, it's really useful!

One minor gripe though... Would it possible to have an option to disable the "Please wait" tab?

I got this working by destroying the WaitView object immediately after opening the file:

 externalOpenUri = (uri, waitView) ->
   fs ?= require 'fs'
   fs.exists(uri, ((exists) ->
     if exists
       open ?= require 'open'
       open(uri, (=> atom.workspace.paneForItem(waitView)?.destroyItem(waitView) if waitView?))
+      atom.workspace.paneForItem(waitView)?.destroyItem(waitView) if waitView?
     else
       setTimeout((() => atom.workspace.paneForItem(waitView)?.destroyItem(waitView) if waitView?), 2000)
       console.error "#{uri} is not a file!"
     )
   )

That's probably not the cleanest way to do it, but it seems to work. It would probably be better to skip creating it instead.

Could an option be added to not create the "Please wait" tab?

Or the waitview itself could have a self destruct timer to automatically close the tab after certain number of seconds.

[sveale]

Thanks :)

If I remember correctly, if nothing is returned by this opener, the file will be opened by the default atom opener, ie. opened in in atom.

I'll look into it.

[sveale]

The whole point of this and this line is to automatically close the "Please wait" tab after the file has been opened. Isn't this happening for you guys?

[kankaristo]

It seems to close for some files (never noticed that before), but for most files it stays open until I close the external program. So I guess this is a bug report, not a feature request. 😄

For example, .ogg and .otf files leave the tab open until I close the external program, but with a .mp4 file, the tab closes after the file is opened.

It seems to depend on the program that the file is opened with. For example, if the file opens in VLC, the tab doesn't close until I quit VLC.

I have both VLC (.ogg) and the font viewer (.otf) in a "single instance" mode, maybe that has something to do with it?

If I already have VLC open, and I open a file with external-open, the tab closes immediately.

[kankaristo]

@sveale, I see that you released 0.62 with the option to disable the wait view, but then reverted the change in 0.63, how come?

I'm still using a modified version of the package because of this, since most files leave the wait view open until I close the external program.